Skip to content

Enable Depth AE Convergence Test with Firmware Version Check - #14621

Merged
Nir-Az merged 1 commit into
realsenseai:developmentfrom
ipilchin1:RSDO-20426-enable_AE_converges_test
Jan 20, 2026
Merged

Nir-Az merged 1 commit into
realsenseai:developmentfrom
ipilchin1:RSDO-20426-enable_AE_converges_test

Conversation

@ipilchin1

Copy link
Copy Markdown
Contributor

Description
Enables the test-depth_ae_convergence.py test which was previously disabled with test:donotrun.

Changes
Removed test:donotrun tag to enable the test
Added firmware version check: test skips if FW ≤ 5.17.0.10
Included D457 camera support (removed !D457 exclusion)
Added import pyrsutils for version comparison

Testing
✅ Verified: Firmware ≤ 5.17.0.10 → test skips gracefully
✅ Verified: Firmware > 5.17.0.10 → test passes successfully
Why
The AE convergence fix was implemented in firmware 5.17.0.10+. This test validates that auto-exposure converges within acceptable time thresholds for both REGULAR and ACCELERATED modes.

Copilot AI review requested due to automatic review settings January 19, 2026 14:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables a previously disabled depth auto-exposure convergence test by adding firmware version validation. The test now runs on devices with firmware > 5.17.0.10 where the AE convergence fix is available.

Changes:

  • Removed test:donotrun tag and !D457 exclusion to enable the test for all D400 devices
  • Added firmware version check to skip test on devices with FW ≤ 5.17.0.10
  • Updated copyright year to 2026

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ipilchin1
ipilchin1 requested review from Nir-Az and ymodlin January 19, 2026 14:50
@ymodlin

ymodlin commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Hi @Nir-Az
I see the test is passing, please confirm

@Nir-Az
Nir-Az merged commit 6bdc088 into realsenseai:development Jan 20, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants