Skip to content

Hdr long test add check - #14809

Merged
Nir-Az merged 5 commits into
realsenseai:developmentfrom
remibettan:hdr-long-test-add-check
Mar 23, 2026
Merged

Nir-Az merged 5 commits into
realsenseai:developmentfrom
remibettan:hdr-long-test-add-check

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

Tracked by: RSDEV-6362

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the D400 HDR long-running live test to add explicit post-condition validation when disabling HDR/emitter options, and adjusts the test runner directives for when the test is executed (RSDEV-6362).

Changes:

  • Removes the Jetson-specific skip directive and keeps the test excluded from non-nightly runs.
  • Adds test.check(...) assertions verifying hdr_enabled is disabled after the streaming sequence-id test.
  • Adds test.check(...) assertions verifying emitter_on_off is disabled after the emitter sequence-id test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread unit-tests/live/d400/test-hdr-long.py Resolved
Comment thread unit-tests/live/d400/test-hdr-long.py Outdated
# test:device D400*
# test:donotrun:!nightly
# test:donotrun:jetson
# test:donotrun:!nightly

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will fail on Jetson no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now yes - until we use the change I did in FW
I ll turn this PR to draft until the fix is in.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add a FW version check as we run and latest and it will only be included in latest

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@remibettan
remibettan marked this pull request as draft March 15, 2026 16:26
@remibettan remibettan closed this Mar 22, 2026
@remibettan

Copy link
Copy Markdown
Contributor Author

not needed

@remibettan remibettan reopened this Mar 22, 2026
remibettan and others added 4 commits March 22, 2026 16:52
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@remibettan
remibettan force-pushed the hdr-long-test-add-check branch from 73c080c to de1a228 Compare March 22, 2026 14:52
@remibettan
remibettan marked this pull request as ready for review March 22, 2026 14:53
@remibettan
remibettan requested a review from Nir-Az March 22, 2026 14:53
Comment thread unit-tests/live/d400/test-hdr-long.py Outdated
if device.supports(rs.camera_info.firmware_version):
fw_version = rsutils.version(device.get_info(rs.camera_info.firmware_version))
if fw_version < rsutils.version(5, 17, 2, 11):
test.exit_and_skip_test("Test requires firmware version 5.17.2.11 or above")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such API exit_and_skip_test

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Nir-Az
Nir-Az merged commit 9d2ad73 into realsenseai:development Mar 23, 2026
26 of 27 checks passed
@remibettan
remibettan deleted the hdr-long-test-add-check branch July 8, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants