Repository navigation
flash 0.96 updates - #15005
Merged
remibettan merged 5 commits intoJul 29, 2026
Merged
flash 0.96 updates#15005
Conversation
remibettan
marked this pull request as ready for review
July 7, 2026 12:07
remibettan
force-pushed
the
sc-flash-096-updates
branch
from
July 7, 2026 12:08
cc3d47b to
6e3e223
Compare
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Automated review by rs-agentic bot — flash 0.96 updates review
…tighten validation, add negative tests - Initialize the 7 float members to 0.0f so a default-constructed calibration_monitor_params serializes deterministic values. - validate_json now checks each field is numeric (surfaces invalid_value_exception instead of nlohmann::type_error), enforces alpha_* in (0, 1], other thresholds > 0, and scale_low_limit_threshold < scale_high_limit_threshold. - Add three negative pytest cases (missing field, wrong type, out-of-range) exercising the new validation via set_safety_interface_config.
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Automated review by rs-agentic bot — flash 0.96 updates follow-up
…tructed state as placeholder The 0.0f member initializers are outside the (0, 1] / >0 ranges enforced by validate_json. Rather than invent non-zero spec-less defaults, keep the zero-fill (matches sibling classes like occupancy_grid_params) and document that a default-constructed instance is a placeholder that must not be round-tripped through to_json/from-json until populated.
remibettan
marked this pull request as draft
July 12, 2026 08:43
Flash 0.96 draft spec (D580_Depth_Safety_Flash_Memory_v0.96_draft.xlsx, Safety Interface Config sheet, rows 67-73) does not specify numeric ranges for the calibration_monitor_params fields — the Comment/Example cells are empty, unlike every other numeric field in the sheet. Drop the range checks that were added on the reviewer's suggestion so that validation stops inventing constraints the spec hasn't set. Keep the presence + is_number() checks; matches sibling classes. Also drop the now-redundant negative pytest for range violations and the stale placeholder comment on the default constructor.
remibettan
marked this pull request as ready for review
July 19, 2026 06:34
Nir-Az
previously approved these changes
Jul 19, 2026
…tle-endian encoding
remibettan
force-pushed
the
sc-flash-096-updates
branch
from
July 22, 2026 10:11
4c7b0a2 to
9952857
Compare
Nir-Az
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-8365
Draft for now because some tests fail (operational-mode), because FW not changed in CI.
Working with adapted FW, test pass.