Skip to content

Fix rs-enumerate-devices DDS domain bug - #15134

Merged
OhadMeir merged 3 commits into
realsenseai:developmentfrom
OhadMeir:development
Jun 2, 2026
Merged

OhadMeir merged 3 commits into
realsenseai:developmentfrom
OhadMeir:development

Conversation

@OhadMeir

@OhadMeir OhadMeir commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Tracked on [RSDEV-11526]

Copilot AI review requested due to automatic review settings June 1, 2026 12:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates rs-enumerate-devices context settings construction to avoid clobbering the DDS settings object when toggling DDS enumeration, addressing the reported DDS domain-related issue (RSDEV-11526).

Changes:

  • Stop overwriting the entire settings["dds"] object and instead set settings["dds"]["enabled"] directly, preserving other DDS keys (e.g., domain).

DUMMY_NAME = "Dummy DDS Device"


def _build_dummy_server(dds, participant):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not splitting this to a separate test file that doesn't require cameras?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not sure all GHA flows build the tools and here we know it was built.
Looking at it now I see we have Win_SH_Py_DDS_CI and Win_SH_Py_DDS_SEC that build both tools and DDS. I can add a skip if tool not found like there is a skip if dds not found.
What do you prefer, should I separate?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to separate as it's a DDS test only, this test run for D400 as well, and they even build with DDS off so it may fail

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@OhadMeir
OhadMeir merged commit 5b945b7 into realsenseai:development Jun 2, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants