Repository navigation
Fix rs-enumerate-devices DDS domain bug - #15134
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates rs-enumerate-devices context settings construction to avoid clobbering the DDS settings object when toggling DDS enumeration, addressing the reported DDS domain-related issue (RSDEV-11526).
Changes:
- Stop overwriting the entire
settings["dds"]object and instead setsettings["dds"]["enabled"]directly, preserving other DDS keys (e.g.,domain).
| DUMMY_NAME = "Dummy DDS Device" | ||
|
|
||
|
|
||
| def _build_dummy_server(dds, participant): |
There was a problem hiding this comment.
Why not splitting this to a separate test file that doesn't require cameras?
There was a problem hiding this comment.
Was not sure all GHA flows build the tools and here we know it was built.
Looking at it now I see we have Win_SH_Py_DDS_CI and Win_SH_Py_DDS_SEC that build both tools and DDS. I can add a skip if tool not found like there is a skip if dds not found.
What do you prefer, should I separate?
There was a problem hiding this comment.
I prefer to separate as it's a DDS test only, this test run for D400 as well, and they even build with DDS off so it may fail
Tracked on [RSDEV-11526]