Repository navigation
Fix D555 ros2-compression test - #15164
Conversation
Nir-Az
left a comment
There was a problem hiding this comment.
rs-agentic-bot automated review
Code-reviewed the three change hunks against the copilot-instructions guidelines and the surrounding test logic. See inline comments below.
rs-agentic-bot automated review — general note
The live test (
There is no lower-bound check on how many frames were actually recorded. On a slow CI runner or a D555 with initialisation delays, Suggestion: add a minimum frame count guard, e.g.: MIN_EXPECTED_FRAMES = 10 # conservative: 3 s × ~30 fps × 0.1 safety factor
assert len(sqlite_pixels) >= MIN_EXPECTED_FRAMES, (
f"Too few frames recorded ({len(sqlite_pixels)}); "
"possible D555 empty-bag regression"
) |
80b99ee to
be4850a
Compare
|
Re: minimum-frame-count guard - the live test already bounds the count: |
Tracked on: [RSDEV-11513]