Skip to content

Fix D555 ros2-compression test - #15164

Merged
OhadMeir merged 1 commit into
realsenseai:developmentfrom
AviaAv:fix-d555-rec-play-sensor-index
Jun 7, 2026
Merged

OhadMeir merged 1 commit into
realsenseai:developmentfrom
AviaAv:fix-d555-rec-play-sensor-index

Conversation

@AviaAv

@AviaAv AviaAv commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Tracked on: [RSDEV-11513]

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs-agentic-bot automated review

Code-reviewed the three change hunks against the copilot-instructions guidelines and the surrounding test logic. See inline comments below.

@Nir-Az

Nir-Az commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

rs-agentic-bot automated review — general note

test_live_compressed_frames_match_playback — consider a minimum-frame-count guard (auto-generated by rs-agentic-bot)

The live test (test_live_compressed_frames_match_playback) currently only asserts:

  1. sqlite_pixels is non-empty
  2. len(sqlite_pixels) == len(playback_pixels)

There is no lower-bound check on how many frames were actually recorded. On a slow CI runner or a D555 with initialisation delays, LIVE_RECORD_SECONDS = 3 might yield fewer frames than expected, and the test could pass with just 1 frame — reducing confidence in the D555 fix.

Suggestion: add a minimum frame count guard, e.g.:

MIN_EXPECTED_FRAMES = 10  # conservative: 3 s × ~30 fps × 0.1 safety factor
assert len(sqlite_pixels) >= MIN_EXPECTED_FRAMES, (
    f"Too few frames recorded ({len(sqlite_pixels)}); "
    "possible D555 empty-bag regression"
)

@AviaAv
AviaAv force-pushed the fix-d555-rec-play-sensor-index branch from 80b99ee to be4850a Compare June 4, 2026 17:54
@AviaAv

AviaAv commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Re: minimum-frame-count guard - the live test already bounds the count: assert sqlite_pixels (non-empty) and assert len(sqlite_pixels) == len(playback_pixels). A fixed minimum is not robust across devices/fps (D555 and D400 record different counts in 3s), so the non-empty + equality checks are preferred over a hardcoded threshold.

@OhadMeir
OhadMeir merged commit 4e054b5 into realsenseai:development Jun 7, 2026
29 of 30 checks passed
@AviaAv
AviaAv deleted the fix-d555-rec-play-sensor-index branch June 7, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants