Skip to content

Rediscovered DDS device name can change - #15266

Merged
OhadMeir merged 1 commit into
realsenseai:developmentfrom
OhadMeir:development
Jun 23, 2026
Merged

OhadMeir merged 1 commit into
realsenseai:developmentfrom
OhadMeir:development

Conversation

@OhadMeir

Copy link
Copy Markdown
Contributor

Name changes after updating FW - dropping "Intel" from name

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated review by rs-agentic bot πŸ€–

PR Review Summary

This PR converts three hard-errors in into softer log messages to handle the legitimate case where a device name changes after a firmware update (dropping "Intel" from the name). The direction is reasonable, but there are two potential bugs and a documentation inconsistency that need attention.

See inline comments for details.

Comment thread third-party/realdds/src/dds-device.cpp Resolved
Comment thread third-party/realdds/src/dds-device.cpp Resolved
Comment thread third-party/realdds/doc/discovery.md Resolved
@sysrsbuild-gh-agentic

Copy link
Copy Markdown
Collaborator

πŸ“‹ Missing test coverage (auto-generated by rs-agentic bot)

This PR changes silent-error behavior β€” the old code would throw and abort rediscovery; the new code logs a warning/error and continues reinitializing. This behavioral change should be covered by a unit test that verifies:

  1. A rediscovered device with a changed name (e.g. dropping "Intel" prefix) logs a WARNING and proceeds to reinitialize successfully.
  2. A rediscovered device with a changed serial number logs an ERROR (and, pending resolution of the bug comment above, either returns early or still reinitializes as intended).
  3. A topic_root change (if it can ever happen) is caught and handled appropriately.

See the existing DDS unit tests under unit-tests/dds/ for reference patterns.

@OhadMeir
OhadMeir requested a review from Nir-Az June 23, 2026 07:45
@OhadMeir OhadMeir changed the title Rediscovered DDS device name can chang Rediscovered DDS device name can change Jun 23, 2026

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@OhadMeir
OhadMeir merged commit 469b182 into realsenseai:development Jun 23, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants