Repository navigation
Rediscovered DDS device name can change - #15266
Conversation
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
Auto-generated review by rs-agentic bot π€
PR Review Summary
This PR converts three hard-errors in into softer log messages to handle the legitimate case where a device name changes after a firmware update (dropping "Intel" from the name). The direction is reasonable, but there are two potential bugs and a documentation inconsistency that need attention.
See inline comments for details.
|
π Missing test coverage (auto-generated by rs-agentic bot) This PR changes silent-error behavior β the old code would throw and abort rediscovery; the new code logs a warning/error and continues reinitializing. This behavioral change should be covered by a unit test that verifies:
See the existing DDS unit tests under |
Name changes after updating FW - dropping "Intel" from name