Repository navigation
D401 GMSL: route RGB controls to dedicated color v4l2 node - #15320
Merged
remibettan merged 5 commits intoJul 1, 2026
Merged
Conversation
Nir-Az
reviewed
Jun 30, 2026
Nir-Az
reviewed
Jun 30, 2026
Nir-Az
reviewed
Jun 30, 2026
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
[rs-agentic bot] Automated review of synchronize event — new commit: pytest-advanced-mode: enable D401
remibettan
added a commit
that referenced
this pull request
Jul 1, 2026
(cherry picked from commit d4c2f7f)
remibettan
added a commit
that referenced
this pull request
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDSO-21631
Overview: On D401 GMSL, RGB controls (Saturation, Sharpness, White Balance, Auto WB) failed to take effect because they were being applied to the wrong v4l2 node.
Why
D401 GMSL exposes color through the depth sensor (
_separate_color = false), but color actually streams from a dedicatedvideo-rs-colornode that also owns the RGB controls — the depth/front node does not. The depth sensor wraps all mi0 nodes in amulti_pins_uvc_devicethat routes every control to the front (depth) node, so RGB controls never reached the color node.Summary
d400_color::create_color_device, when the device is MIPI withRS401_GMSL_PID, locate thecolorentry incolor_devs_info_mi0and build a dedicateduvc_sensor(_raw_color_ep) bound to that node.register_options, use_raw_color_ep(when set) as the target for Saturation and Sharpness — switching fromregister_puto an explicituvc_pu_optionon the right endpoint — and for the existing White Balance / Auto WB options. Other devices keep usingget_raw_color_sensor()._raw_color_epmember tod400_color.hwith a comment pointing back tocreate_color_device.pytest-rgb-options-metadata-consistency.py: dropsdevice_excludefor D405 and D401, and falls back tofirst_depth_sensor()whenfirst_color_sensor()throws — D405 and D401 GMSL expose color through the depth sensor.pytest-advanced-mode.py: dropsdevice_exclude("D401")— advanced-mode is now expected to work on D401.pytest-presets.py: dropsdevice_exclude("D401")and updates thefirst_color_sensor()fallback — D401 falls back tofirst_depth_sensor(), D405 skips with a hue-preservation reason (default_405inpresets.cppdeliberately does not reset color hue on preset apply), D421 keeps its explicit "no color sensor" skip. On D401 GMSL the test skips cleanly at thesupports(rs.option.hue)guard since HUE isn't registered on MIPI.Test plan
_raw_color_epstays null, fallback path unchanged).pytest-rgb-options-metadata-consistency.py(nightly) — passes.pytest-rgb-options-metadata-consistency.py(nightly) — passes.pytest-advanced-mode.py(nightly) — passes.pytest-presets.py(nightly) — passes.pytest-presets.py(nightly) —test_setting_color_optionsskips with the hue-preservation reason; other tests in the file pass.pytest-uvc-power-stress-test.py(weekly, with-r) — passes.