Skip to content

Reduce hardware/nightly-only unit tests: profile-eq β†’ sw-device, drop extrinsics, un-gate waiting-on - #15377

Merged
Nir-Az merged 5 commits into
realsenseai:developmentfrom
Nir-Az:profile-eq-sw-device
Jul 9, 2026
Merged

Nir-Az merged 5 commits into
realsenseai:developmentfrom
Nir-Az:profile-eq-sw-device

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Jul 8, 2026 •

Copy link
Copy Markdown
Collaborator

Overview: Reduces unit tests that unnecessarily require a camera or the nightly context. Converts test-profile-eq to a hardware-free software-device test, removes the obsolete test-extrinsics memory-leak test, and makes test-waiting-on run in every build instead of only nightly.

Tracked on [RSDSO-21735]

Why

  • test-profile-eq only used a device to obtain stream profiles for testing video_stream_profile::operator== β€” pure SDK logic that needs no hardware.
  • test-extrinsics was a timing/delay-based memory-leak test already marked donotrun, superseded by the t2ff pipeline/sensor tests.
  • test-waiting-on (rsutils timing) is a self-contained non-live test with no reason to be gated to nightly.

Summary

  • Moved unit-tests/live/test-profile-eq.cpp β†’ unit-tests/sw-dev/test-profile-eq.cpp and rewrote it to drive video_stream_profile::operator== via a software_device: two profiles equal as base stream_profiles but differing in resolution must compare unequal, and two identical profiles must compare equal. Leaving live/ also drops the live tag, so it runs without a camera.
  • Deleted unit-tests/live/memory/test-extrinsics.cpp.
  • Removed the //#test:donotrun:!nightly directive from unit-tests/rsutils/time/test-waiting-on.cpp.

Test plan

  • Built and ran test-sw-dev-profile-eq (Release, Windows) β€” 8 assertions, all pass, no device attached.
  • Built and ran test-rsutils-time-waiting-on (Release, Windows) in a normal (non-nightly) run β€” 12 assertions / 6 cases, all pass.
  • LibCI green across platforms.

πŸ€– Generated by AI

@Nir-Az Nir-Az changed the title Convert test-profile-eq to a software-device test and remove obsolete test-extrinsics Reduce hardware/nightly-only unit tests: profile-eq β†’ sw-device, drop extrinsics, un-gate waiting-on Jul 8, 2026
@Nir-Az
Nir-Az requested a review from Binyaminp July 8, 2026 06:59

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ€– [rs-agentic bot] Reviewed the new synchronize push (commit 24db981).

This push appears to be a rebase onto the latest development branch. The actual PR diff (relative to the development base) remains the same 4 files reviewed previously:

  • unit-tests/sw-dev/test-profile-eq.cpp (added)
  • unit-tests/live/test-profile-eq.cpp (removed)
  • unit-tests/live/memory/test-extrinsics.cpp (removed)
  • unit-tests/rsutils/time/test-waiting-on.cpp (donotrun gate lifted)

Status of prior review threads:

Thread Status
Duplicate uid=0 across streams βœ… Resolved β€” distinct uids 1/2/3 applied
Fragile index-based profile access βœ… Resolved β€” attribute-based selection applied
base_equal assertion missing context comment βœ… Resolved β€” clarifying comment added
donotrun:!nightly removal is out-of-scope βœ… Resolved β€” acknowledged as intentional, approved

No new issues found in the rebased code. All 4 change-approved confirmations stand.

@Nir-Az
Nir-Az merged commit 0c57edd into realsenseai:development Jul 9, 2026
29 checks passed
@Nir-Az
Nir-Az deleted the profile-eq-sw-device branch July 9, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants