Repository navigation
Reduce hardware/nightly-only unit tests: profile-eq β sw-device, drop extrinsics, un-gate waiting-on - #15377
Merged
Conversation
Binyaminp
approved these changes
Jul 8, 2026
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
π€ [rs-agentic bot] Reviewed the new synchronize push (commit 24db981).
This push appears to be a rebase onto the latest development branch. The actual PR diff (relative to the development base) remains the same 4 files reviewed previously:
unit-tests/sw-dev/test-profile-eq.cpp(added)unit-tests/live/test-profile-eq.cpp(removed)unit-tests/live/memory/test-extrinsics.cpp(removed)unit-tests/rsutils/time/test-waiting-on.cpp(donotrun gate lifted)
Status of prior review threads:
| Thread | Status |
|---|---|
Duplicate uid=0 across streams |
β Resolved β distinct uids 1/2/3 applied |
| Fragile index-based profile access | β Resolved β attribute-based selection applied |
base_equal assertion missing context comment |
β Resolved β clarifying comment added |
donotrun:!nightly removal is out-of-scope |
β Resolved β acknowledged as intentional, approved |
No new issues found in the rebased code. All 4 change-approved confirmations stand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Reduces unit tests that unnecessarily require a camera or the nightly context. Converts
test-profile-eqto a hardware-free software-device test, removes the obsoletetest-extrinsicsmemory-leak test, and makestest-waiting-onrun in every build instead of only nightly.Tracked on [RSDSO-21735]
Why
test-profile-eqonly used a device to obtain stream profiles for testingvideo_stream_profile::operator==β pure SDK logic that needs no hardware.test-extrinsicswas a timing/delay-based memory-leak test already markeddonotrun, superseded by the t2ff pipeline/sensor tests.test-waiting-on(rsutils timing) is a self-contained non-live test with no reason to be gated to nightly.Summary
unit-tests/live/test-profile-eq.cppβunit-tests/sw-dev/test-profile-eq.cppand rewrote it to drivevideo_stream_profile::operator==via asoftware_device: two profiles equal as basestream_profiles but differing in resolution must compare unequal, and two identical profiles must compare equal. Leavinglive/also drops thelivetag, so it runs without a camera.unit-tests/live/memory/test-extrinsics.cpp.//#test:donotrun:!nightlydirective fromunit-tests/rsutils/time/test-waiting-on.cpp.Test plan
test-sw-dev-profile-eq(Release, Windows) β 8 assertions, all pass, no device attached.test-rsutils-time-waiting-on(Release, Windows) in a normal (non-nightly) run β 12 assertions / 6 cases, all pass.π€ Generated by AI