Repository navigation
CI: Fix race condition when building with ROS 2 - #15387
Conversation
18b2361 to
9427e7e
Compare
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
🤖 rs-agentic bot — Synchronize review (commit 18b2361)
✅ Positive change in this push
The author added persist-credentials: false to the checkout step in both workflow files. This directly addresses the Aikido security finding and is the correct hardening approach — well done.
⚠️ Outstanding concern: fetch-depth: 0 (from previous review)
My previous inline comments about fetch-depth: 0 have not been addressed. The code still fetches the full git history in both workflow files:
fetch-depth: 0The commit message does provide a rationale:
"This ensures the git repository has all commits and refs properly initialized before vcs import tries to access them."
If vcs import (or action-ros-ci internally) genuinely requires full history to resolve refs/tags, then fetch-depth: 0 is justified — however, please explicitly confirm this with one of the following actions:
- Add a comment in the YAML explaining why full history is needed, e.g.:
# fetch-depth: 0 required because action-ros-ci/vcs-import needs full # git history to resolve tags used during the build fetch-depth: 0
- Or change to
fetch-depth: 1if full history is not strictly needed (this is typically sufficient for a CI build).
Until this is clarified/resolved, the fetch-depth: 0 review threads remain open.
This comment was auto-generated by the rs-agentic bot.
|
✅ [rs-agentic bot] change approved The two previous bot comments flagging
The fix looks good and correctly resolves the race condition described in #15386 by ensuring the repository checkout step (with submodules) happens before the |
To resolve the race condition, the source files are retrieved from the repository in a separate step. Fixes realsenseai#15386
🤖 rs-agentic bot — Synchronize review (commit 9a583da)✅ change approvedThis push is a merge from the Reviewing the outstanding concerns from my previous inline comments:
The PR diff is clean, minimal, and correctly structured. No new issues introduced by this merge commit. This comment was auto-generated by the rs-agentic bot. |
|
change approved
The updated checkout step in both
All prior review concerns have been resolved. |
|
Can someone merge this PR, since other PRs depend on it, to help prevent failed build jobs? |
Fixes #15386