Skip to content

d5x5 TC: downgrade CRC32 diagnostic logs from INFO to DEBUG (RSDEV-13186) - #15496

Merged
remibettan merged 2 commits into
realsenseai:developmentfrom
remibettan:tc-d5x5-crc-logs-to-debug
Aug 3, 2026
Merged

remibettan merged 2 commits into
realsenseai:developmentfrom
remibettan:tc-d5x5-crc-logs-to-debug

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

Tracked by: RSDEV-13186

Downgrade two LOG_INFO lines in d500_auto_calibrated::run_interactive_triggered_calibration to LOG_DEBUG:

  • Interactive TC: depth calibration CRC32 before RUN = 0x… / after COMMIT = 0x…
  • Interactive TC: RAM depth calibration CRC32 before TRY … = 0x… / after TRY … = 0x…

Why

These were introduced as intentional-permanent instrumentation in #15486 to prove out FW-side COMMIT persistence and TRY-side RAM-swap end to end. The FW team has since confirmed both behaviours: verified CRC deltas before/after COMMIT and before/after TRY_NEW / TRY_OLD on the interactive flow. The logs served their purpose and no longer need to sit at INFO on every user session — a Debug-severity gate keeps them accessible for future regression diagnosis without adding six LOG_INFO lines per interactive TC round-trip on a normal viewer run.

No behavioural change beyond log severity.

Test plan

  • Build clean (viewer built locally, no compile errors).
  • Interactive TC round-trip on D5x5: no CRC log lines appear at default INFO severity; enabling Debug in the viewer's log panel makes them appear as before.
  • D585S (0x0B6B) / D555 regression — this branch does not touch the legacy-path or D400 dispatchers.

🤖 Generated by AI

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-generated review by rs-agentic bot

Clean, minimal change — no bugs or guideline violations found.

  • ✅ Both LOG_INFO → LOG_DEBUG downgrades are correct and consistent across the two CRC log helpers.
  • ✅ Continuation-line indentation adjusted correctly to stay aligned under the opening " in each LOG_DEBUG call.
  • ✅ No behavioural change; no dead code left behind.
  • ✅ Branch targets development and naming follows conventions.

LGTM from a code-review perspective.

@remibettan
remibettan requested a review from Nir-Az August 3, 2026 11:21

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-generated review by rs-agentic bot

Reviewed new push (1e0c34f).

The LOG_INFO → LOG_DEBUG downgrades are confirmed correct — no issues.

Undocumented scope in this push: several LOG_WARNING strings also had Unicode em-dashes (—) and arrows (→) replaced with ASCII equivalents (- / ->). These are harmless but not mentioned in the PR description or test plan. Consider noting them in the PR body or squashing into the same commit message for traceability.

No bugs found.

@remibettan
remibettan merged commit 837c9b9 into realsenseai:development Aug 3, 2026
34 checks passed
@remibettan
remibettan deleted the tc-d5x5-crc-logs-to-debug branch August 4, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants