Repository navigation
d5x5 TC: downgrade CRC32 diagnostic logs from INFO to DEBUG (RSDEV-13186) - #15496
Merged
remibettan merged 2 commits intoAug 3, 2026
Merged
Conversation
…LOG_INFO to LOG_DEBUG
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Auto-generated review by rs-agentic bot
Clean, minimal change — no bugs or guideline violations found.
- ✅ Both
LOG_INFO→LOG_DEBUGdowngrades are correct and consistent across the two CRC log helpers. - ✅ Continuation-line indentation adjusted correctly to stay aligned under the opening
"in eachLOG_DEBUGcall. - ✅ No behavioural change; no dead code left behind.
- ✅ Branch targets
developmentand naming follows conventions.
LGTM from a code-review perspective.
…render them as '?'
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Auto-generated review by rs-agentic bot
Reviewed new push (1e0c34f).
The LOG_INFO → LOG_DEBUG downgrades are confirmed correct — no issues.
Undocumented scope in this push: several LOG_WARNING strings also had Unicode em-dashes (—) and arrows (→) replaced with ASCII equivalents (- / ->). These are harmless but not mentioned in the PR description or test plan. Consider noting them in the PR body or squashing into the same commit message for traceability.
No bugs found.
Nir-Az
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-13186
Downgrade two
LOG_INFOlines ind500_auto_calibrated::run_interactive_triggered_calibrationtoLOG_DEBUG:Interactive TC: depth calibration CRC32 before RUN = 0x…/after COMMIT = 0x…Interactive TC: RAM depth calibration CRC32 before TRY … = 0x…/after TRY … = 0x…Why
These were introduced as intentional-permanent instrumentation in #15486 to prove out FW-side COMMIT persistence and TRY-side RAM-swap end to end. The FW team has since confirmed both behaviours: verified CRC deltas before/after COMMIT and before/after TRY_NEW / TRY_OLD on the interactive flow. The logs served their purpose and no longer need to sit at INFO on every user session — a Debug-severity gate keeps them accessible for future regression diagnosis without adding six
LOG_INFOlines per interactive TC round-trip on a normal viewer run.No behavioural change beyond log severity.
Test plan
🤖 Generated by AI