Skip to content

Security: Fix critical and high vulnerabilities (Aikido automated scan) - #15520

Merged
AviaAv merged 1 commit into
developmentfrom
fix/aikido-auto
Aug 9, 2026
Merged

AviaAv merged 1 commit into
developmentfrom
fix/aikido-auto

Conversation

@sysrsbuild-gh-agentic

Copy link
Copy Markdown
Collaborator

This PR automatically fixes critical and high severity vulnerabilities identified by the Aikido security scanner.

Fixed Issues:

@sysrsbuild-gh-agentic

Copy link
Copy Markdown
Collaborator Author

rs-agentic bot — automated review

✅ Commit 115da0c reviewed.

The socket.io-parser bump 4.2.6 → 4.2.7 (CVE-2026-69185) looks correct — version, resolved URL, and integrity hash are all present.

Note: ~18 packages have "peer": true removed from package-lock.json as a side-effect of the lock file regeneration (likely a npm version difference). This is not a bug — auto-generated content — but makes the diff noisier than strictly needed. No action required.

No BUGs found in this commit.

AviaAv
AviaAv previously approved these changes Aug 6, 2026

@AviaAv AviaAv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rs-agentic bot] Automated review — synchronize event

"node_modules/socket.io-parser": {
"version": "4.2.6",
"version": "4.2.7",
"resolved": "https://registry.npmjs.org/socket.io-parser/-/socket.io-parser-4.2.7.tgz",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [rs-agentic bot] — Potential BUG: Only package-lock.json is updated, not package.json. Since socket.io-parser is a transitive dependency, a fresh npm install may revert this back to 4.2.6. To make the fix durable, add an overrides entry in package.json:

"overrides": {
  "socket.io-parser": "^4.2.7"
}

This comment was auto-generated by the rs-agentic bot.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applicable here — npm install can't revert this to 4.2.6.

socket.io-client@4.8.3 declares socket.io-parser: "~4.2.4", i.e. >=4.2.4 <4.3.0.
Published 4.2.x versions are 4.2.0 … 4.2.6, 4.2.7 — so 4.2.7 is the highest
version in range. npm resolves a range to the highest match, and with the
lockfile present it's pinned there anyway. There's no resolution path back
to 4.2.6.

overrides are needed when the parent's declared range excludes the fix —
that's why ws and form-data have entries. Not the case here, so an
override would be a no-op with ongoing maintenance cost.

Verified locally on this commit:

  • npm ci → clean
  • installed socket.io-parser = 4.2.7
  • npm run build + npm test → 115/115 pass

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change approved

AviaAv
AviaAv previously approved these changes Aug 6, 2026

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rs-agentic bot] Automated review — synchronize event (commit ad970e2)

Reviewed new commit. One regression concern flagged inline.

"recharts": "^2.9.0",
"socket.io-client": "^4.6.0",
"socket.io-client": "^4.7.2",
"three": "^0.158.0",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [rs-agentic bot] — Potential BUG: socket.io-client is downgraded 4.8.3 → 4.7.2 (range narrowed ^4.6.0 → ^4.7.2), pulling transitive regressions: engine.io-client 6.6.4→6.5.4 and xmlhttprequest-ssl 2.1.2→2.0.0. @AviaAv had already confirmed the previous commit had the CVE fix (socket.io-parser@4.2.7) in place without any client-version change — this downgrade appears unnecessary and introduces avoidable risk.
This comment was auto-generated by the rs-agentic bot.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change approved

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rs-agentic bot] Automated review — synchronize event (commit 8342dc4)

change approved

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rs-agentic bot] Automated review — synchronize event (commit f0855fa)

change approved

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rs-agentic bot] Automated review — synchronize event (commit e4d3955)

change approved

AviaAv
AviaAv previously approved these changes Aug 9, 2026
@AviaAv
AviaAv merged commit d191252 into development Aug 9, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants