Repository navigation
Security: Fix critical and high vulnerabilities (Aikido automated scan) - #15520
Conversation
✅ Commit The Note: ~18 packages have No BUGs found in this commit. |
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
[rs-agentic bot] Automated review — synchronize event
| "node_modules/socket.io-parser": { | ||
| "version": "4.2.6", | ||
| "version": "4.2.7", | ||
| "resolved": "https://registry.npmjs.org/socket.io-parser/-/socket.io-parser-4.2.7.tgz", |
There was a problem hiding this comment.
package-lock.json is updated, not package.json. Since socket.io-parser is a transitive dependency, a fresh npm install may revert this back to 4.2.6. To make the fix durable, add an overrides entry in package.json:
"overrides": {
"socket.io-parser": "^4.2.7"
}This comment was auto-generated by the rs-agentic bot.
There was a problem hiding this comment.
Not applicable here — npm install can't revert this to 4.2.6.
socket.io-client@4.8.3 declares socket.io-parser: "~4.2.4", i.e. >=4.2.4 <4.3.0.
Published 4.2.x versions are 4.2.0 … 4.2.6, 4.2.7 — so 4.2.7 is the highest
version in range. npm resolves a range to the highest match, and with the
lockfile present it's pinned there anyway. There's no resolution path back
to 4.2.6.
overrides are needed when the parent's declared range excludes the fix —
that's why ws and form-data have entries. Not the case here, so an
override would be a no-op with ongoing maintenance cost.
Verified locally on this commit:
npm ci→ clean- installed
socket.io-parser= 4.2.7 npm run build+npm test→ 115/115 pass
There was a problem hiding this comment.
change approved
e0d2b86 to
ad970e2
Compare
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
[rs-agentic bot] Automated review — synchronize event (commit ad970e2)
Reviewed new commit. One regression concern flagged inline.
| "recharts": "^2.9.0", | ||
| "socket.io-client": "^4.6.0", | ||
| "socket.io-client": "^4.7.2", | ||
| "three": "^0.158.0", |
There was a problem hiding this comment.
socket.io-client is downgraded 4.8.3 → 4.7.2 (range narrowed ^4.6.0 → ^4.7.2), pulling transitive regressions: engine.io-client 6.6.4→6.5.4 and xmlhttprequest-ssl 2.1.2→2.0.0. @AviaAv had already confirmed the previous commit had the CVE fix (socket.io-parser@4.2.7) in place without any client-version change — this downgrade appears unnecessary and introduces avoidable risk.
This comment was auto-generated by the rs-agentic bot.
There was a problem hiding this comment.
change approved
ad970e2 to
8342dc4
Compare
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
[rs-agentic bot] Automated review — synchronize event (commit 8342dc4)
change approved
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
[rs-agentic bot] Automated review — synchronize event (commit f0855fa)
change approved
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
[rs-agentic bot] Automated review — synchronize event (commit e4d3955)
change approved
e4d3955 to
1fd776f
Compare
This PR automatically fixes critical and high severity vulnerabilities identified by the Aikido security scanner.
Fixed Issues: