Repository navigation
Fix IMU HW FPS 0 for D500 GMSL - #15521
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
[rs-agentic bot - auto review]
The condition change from buffer->get_length_frame_only() <= 64 to _info.mi == 4 correctly fixes the D500/GMSL case where the 256-byte frame was bypassing populate_imu_data.
Potential concern: populate_imu_data reads the timestamp as frame_start + offsetof(hid_mipi_data, hwTs). If D500's 256-byte frame layout differs from hid_mipi_data (which appears sized for D400's 64-byte frame), the timestamp offset will be wrong and IMU timestamps will be corrupted on D500. Please confirm hid_mipi_data::hwTs offset is valid for both D400 and D500 frame formats.
Nir-Az
reviewed
Aug 6, 2026
Nir-Az
approved these changes
Aug 9, 2026
2 tasks done
Nir-Az
pushed a commit
that referenced
this pull request
Aug 11, 2026
Nir-Az
added a commit
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-13410]