Repository navigation
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Auto-generated by rs-agentic bot
Enhancement: Both log.warning and pytest.skip label this as "FW bug", but the PR description notes the root cause is still open — it may be a wrong constant in the test rather than a FW defect. Consider a neutral wording, e.g.:
log.warning( "Skipping test_close_range_threshold: threshold default mismatch, see RSDEV-13516" )
pytest.skip( "threshold default mismatch tracked by RSDEV-13516" )This avoids prematurely attributing blame before RSDEV-13516 is resolved.
Signed-off-by: Yogev Modlin <yogev.modlin@realsenseai.com>
ymodlin
force-pushed
the
RSDEV-13516-skip-close-range-threshold
branch
from
August 9, 2026 06:27
48964eb to
4b6c12b
Compare
ymodlin
marked this pull request as ready for review
August 9, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
test_close_range_threshold(D555/D585,unit-tests/live/d500/pytest-close-range.py) and its now-unusedTHRESHOLD_DEFAULTconstant. Tracked by RSDEV-13516.Why
The test asserted that the
thresholdembedded-filter option reports the spec default550.0:FW reports a different, per-unit value instead:
This blocked both the Windows and Linux legs of
LRS_libci_pipelinenightly (#17548, #17552, #17553) — it was the only failing test in an otherwise green pipeline.Evidence it is not flaky, and not an SDK regression
7.58.38429.9662, below theMIN_FW_BY_DEVICEgate (7.58.39807.10573). There is no prior passing baseline for this assertion; it is day-1 exposure following RSDEV-12321 ("D555/D585 – MinZ Control (DDS/USB)"), not a regression.Open question (owned by RSDEV-13516)
Is
550.0a universal spec default (FW bug), or is the default calibration-derived (in which case the assertion was wrong to begin with)? Until that is decided the expected value cannot be re-baselined, so the test is removed rather than re-pointed at 487/491.Scope note
The whole test is removed, which also drops the
_set_get_round_trip( threshold, 600.0 )coverage that currently passes — set/get on the option itself is working. When RSDEV-13516 is resolved, the test should be reintroduced with the correct expectation for the default value (or with the default-value assertion dropped and only the round-trip kept). A comment recording this is on the ticket.THRESHOLD_DEFAULThad no other reference in the repo, so it is removed with the test.Testing
python3 -m py_compileclean.