Skip to content

Cherry-pick #15600: dual RGB firmware guard - #15603

Merged
Nir-Az merged 1 commit into
realsenseai:r/2.58.4from
Nir-Az:dual-rgb-fw-guard-2584
Aug 27, 2026
Merged

Nir-Az merged 1 commit into
realsenseai:r/2.58.4from
Nir-Az:dual-rgb-fw-guard-2584

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Overview: Cherry-pick of #15600 to r/2.58.4 — D401 GMSL raw dual-RGB (Color + Color 1) is exposed only on firmware 5.17.4.13 and newer; older firmware offers the ISP color path only.

Why

Raw dual-RGB on the D401 GMSL requires firmware 5.17.4.13+. Without the gate, older firmware advertises color streams that never resolve. Wanted in the 2.58.4 release. Original PR merged to development as dafe93cc.

Summary

  • src/ds/d400/d400-device.cpp, src/ds/d400/d400-color.cpp: register the raw dual-RGB color streams only when _fw_version >= 5.17.4.13.
  • common/subdevice-model.cpp/.h: is_dual_color_subdevice() returns false below 5.17.4.13, so the Viewer shows a single ISP color stream (no Color 1).
  • Docs: add doc/rs400/d401_dual_rgb_gmsl.md, linked from doc/readme.md.
  • Gated on the D401 GMSL product id; no other model is affected.

Test plan

  • Cherry-pick applies cleanly (git cherry-pick -m 1 dafe93cc); diff content identical to the original merge (hunk offsets only).
  • realsense2 builds on Windows (MSVC, Release) on the cherry-pick branch.
  • LibCI on the cherry-pick branch.

🤖 Generated by AI

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated review by rs-agentic bot.

Overall the cherry-pick logic is sound. Two items worth confirming before merge — details inline.

Comment thread src/ds/d400/d400-color.cpp Resolved
Comment thread src/ds/d400/d400-device.cpp Resolved
@Nir-Az
Nir-Az merged commit f92068d into realsenseai:r/2.58.4 Aug 27, 2026
29 of 30 checks passed
@Nir-Az
Nir-Az deleted the dual-rgb-fw-guard-2584 branch August 27, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants