Repository navigation
Cherry-pick #15600: dual RGB firmware guard - #15603
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Auto-generated review by rs-agentic bot.
Overall the cherry-pick logic is sound. Two items worth confirming before merge — details inline.
alexkunin-gh
approved these changes
Aug 27, 2026
ashrafk93
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Cherry-pick of #15600 to
r/2.58.4— D401 GMSL raw dual-RGB (Color+Color 1) is exposed only on firmware 5.17.4.13 and newer; older firmware offers the ISP color path only.Why
Raw dual-RGB on the D401 GMSL requires firmware 5.17.4.13+. Without the gate, older firmware advertises color streams that never resolve. Wanted in the 2.58.4 release. Original PR merged to
developmentasdafe93cc.Summary
src/ds/d400/d400-device.cpp,src/ds/d400/d400-color.cpp: register the raw dual-RGB color streams only when_fw_version >= 5.17.4.13.common/subdevice-model.cpp/.h:is_dual_color_subdevice()returnsfalsebelow 5.17.4.13, so the Viewer shows a single ISP color stream (noColor 1).doc/rs400/d401_dual_rgb_gmsl.md, linked fromdoc/readme.md.Test plan
git cherry-pick -m 1 dafe93cc); diff content identical to the original merge (hunk offsets only).realsense2builds on Windows (MSVC, Release) on the cherry-pick branch.🤖 Generated by AI