Repository navigation
Enable RUM upload to server - #15676
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Auto-generated review by rs-agentic bot. Found 2 bugs and 1 minor risk item.
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
π€ [rs-agentic bot] BUG β _consented member not reset from persisted config on popup open
The previous static bool consented was moved to bool _consented = false; as a member variable, but the root issue is not resolved: _consented is never re-initialized from the saved config value when the popup opens. If the user checks the box, closes the popup via Escape (or any path that doesn't press OK), then reopens it, _consented will still be true β a misleading pre-checked state.
Fix: reset _consented at the top of draw_consent_popup, before rendering the checkbox:
_consented = config_file::instance().get( configurations::stats::rum_cloud_enabled, false );
Nir-Az
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDEV-14281]