Skip to content

Enable RUM upload to server - #15676

Merged
AviaAv merged 3 commits into
realsenseai:developmentfrom
AviaAv:rum-viewer-upload
Sep 15, 2026
Merged

AviaAv merged 3 commits into
realsenseai:developmentfrom
AviaAv:rum-viewer-upload

Conversation

@AviaAv

@AviaAv AviaAv commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Tracked on: [RSDEV-14281]

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated review by rs-agentic bot. Found 2 bugs and 1 minor risk item.

Comment thread common/http/curl-wrapper.cpp Resolved
Comment thread common/rum-uploader/rum-uploader.cpp Resolved
Comment thread common/rum-uploader/rum-uploader.cpp Resolved

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ€– [rs-agentic bot] BUG – _consented member not reset from persisted config on popup open

The previous static bool consented was moved to bool _consented = false; as a member variable, but the root issue is not resolved: _consented is never re-initialized from the saved config value when the popup opens. If the user checks the box, closes the popup via Escape (or any path that doesn't press OK), then reopens it, _consented will still be true β€” a misleading pre-checked state.

Fix: reset _consented at the top of draw_consent_popup, before rendering the checkbox:

_consented = config_file::instance().get( configurations::stats::rum_cloud_enabled, false );

Comment thread common/rum-uploader/rum-uploader.h Resolved
@AviaAv
AviaAv requested a review from Nir-Az September 15, 2026 06:47
@AviaAv
AviaAv merged commit 1959040 into realsenseai:development Sep 15, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants