Repository navigation
Support multiple formats for dual RGB raw - #15688
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Automated review by rs-agentic bot.
OhadMeir
force-pushed
the
raw16_dual_colo
branch
from
September 16, 2026 08:40
6622ffa to
3fdba38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: D585 2C now exposes the RAW16 raw-Bayer color profile on both color streams, as the 3C RGB camera already did.
Tracked on [RSDEV-12539]
Why
The dual-color path matched only the
BA10fourcc, which no D5x5 firmware or driver publishes. Read straight from the USB configuration descriptor, the 2C color pins advertiseRW16(vendor GUID52573136-661a-42a2-9065-d01814a8ef8a, 1600x1300, 16 bpp); WMF normalizes that toBYR2, V4L2 passes it through, and on GMSL the d4xx driver names the same dataGR16. None of those matched, so the profile was dropped during enumeration and never reached Color 1 / Color 2.3C was already correct —
d500-color.cppmapsRW16andBYR2.Summary
d500-dual-color.cpp: collected the color-pin encodings into onecolor_pin_formatstable and addedRW16,BYR2andGR16.BA10kept as an alias.resolve_color_streamgates on that table instead of a hardcoded fourcc chain, so the raw profile is retyped to Color 1 / Color 2 like the other encodings.d500-color.cpp: addedGR16for the GMSL 3C path.Test plan
Color 1andColor 2report1600x1300 RAW16 @ 30/15 Hz; RGB8/BGR8/RGBA8/BGRA8/NV12/YUYV unchanged at 7 resolutions each, Infrared unchangedRS2_OPTION_SENSORS_CONFIG_MODE=0:Color 1600x1300 RAW16 @ 25/15 Hz, no regressionrealsense2andrealsense-viewerbuild clean (VS 2022, Release)RW16path has not been run on a bench carrying this firmwareGR16: by inspection only — the dual-color GMSL path has separate gaps (RSDEV-13340) before RAW16 can surface there🤖 Generated by AI