Skip to content

Support multiple formats for dual RGB raw - #15688

Merged
Nir-Az merged 1 commit into
realsenseai:developmentfrom
OhadMeir:raw16_dual_colo
Sep 16, 2026
Merged

Nir-Az merged 1 commit into
realsenseai:developmentfrom
OhadMeir:raw16_dual_colo

Conversation

@OhadMeir

@OhadMeir OhadMeir commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Overview: D585 2C now exposes the RAW16 raw-Bayer color profile on both color streams, as the 3C RGB camera already did.

Tracked on [RSDEV-12539]

Why

The dual-color path matched only the BA10 fourcc, which no D5x5 firmware or driver publishes. Read straight from the USB configuration descriptor, the 2C color pins advertise RW16 (vendor GUID 52573136-661a-42a2-9065-d01814a8ef8a, 1600x1300, 16 bpp); WMF normalizes that to BYR2, V4L2 passes it through, and on GMSL the d4xx driver names the same data GR16. None of those matched, so the profile was dropped during enumeration and never reached Color 1 / Color 2.

3C was already correct — d500-color.cpp maps RW16 and BYR2.

Summary

  • d500-dual-color.cpp: collected the color-pin encodings into one color_pin_formats table and added RW16, BYR2 and GR16. BA10 kept as an alias.
  • resolve_color_stream gates on that table instead of a hardcoded fourcc chain, so the raw profile is retyped to Color 1 / Color 2 like the other encodings.
  • d500-color.cpp: added GR16 for the GMSL 3C path.

Test plan

  • D585 2C, FW 7.58.46239.15244, Windows/WMF: Color 1 and Color 2 report 1600x1300 RAW16 @ 30/15 Hz; RGB8/BGR8/RGBA8/BGRA8/NV12/YUYV unchanged at 7 resolutions each, Infrared unchanged
  • Streamed both color streams: 10 frames each, 4,160,000 B = 1600x1300x2, uint16, values 68-1023 (10-bit Bayer in a 16-bit container)
  • Same unit switched to 3C via RS2_OPTION_SENSORS_CONFIG_MODE=0: Color 1600x1300 RAW16 @ 25/15 Hz, no regression
  • realsense2 and realsense-viewer build clean (VS 2022, Release)
  • Linux/V4L2 2C: the RW16 path has not been run on a bench carrying this firmware
  • GMSL GR16: by inspection only — the dual-color GMSL path has separate gaps (RSDEV-13340) before RAW16 can surface there

🤖 Generated by AI

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by rs-agentic bot.

Comment thread src/ds/d500/d500-dual-color.cpp Resolved
Comment thread src/ds/d500/d500-dual-color.cpp Resolved

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit b320420 into realsenseai:development Sep 16, 2026
35 checks passed
@OhadMeir
OhadMeir deleted the raw16_dual_colo branch November 3, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants