Skip to content

Remove dead get_a_b call from update_samples_base - #15724

Merged
Nir-Az merged 1 commit into
realsenseai:developmentfrom
Nir-Az:remove-dead-get-a-b
Sep 28, 2026
Merged

Nir-Az merged 1 commit into
realsenseai:developmentfrom
Nir-Az:remove-dead-get-a-b

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

Overview: Removes a dead get_a_b() call in the global-timestamp clock fit. No behavior change.

Tracked on [RSDSO-21977]

Why

CLinearCoefficients::update_samples_base() computed blended coefficients into two locals and never used them. get_a_b() is const with no side effects, so the call did nothing. Flagged by the rs-agentic review on #15723.

Summary

  • Drop the unused double a, b; and get_a_b(x + base_x, a, b); from update_samples_base().

Test plan

  • test-synchronization-timestamps (static build): 6/6 pass.

🤖 Generated by AI

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs-agentic auto-review

Verified the removal: get_a_b() is declared const (no side effects on member state), and the computed a/b locals were never read after the call. The base-shift logic that follows is unaffected. Dead code removal is correct — no issues found.

@Nir-Az
Nir-Az requested a review from OhadMeir September 27, 2026 12:49
@Nir-Az
Nir-Az merged commit aeb4e32 into realsenseai:development Sep 28, 2026
35 checks passed
@Nir-Az
Nir-Az deleted the remove-dead-get-a-b branch September 28, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants