Repository navigation
Remove dead get_a_b call from update_samples_base - #15724
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
rs-agentic auto-review
Verified the removal: get_a_b() is declared const (no side effects on member state), and the computed a/b locals were never read after the call. The base-shift logic that follows is unaffected. Dead code removal is correct — no issues found.
OhadMeir
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Removes a dead
get_a_b()call in the global-timestamp clock fit. No behavior change.Tracked on [RSDSO-21977]
Why
CLinearCoefficients::update_samples_base()computed blended coefficients into two locals and never used them.get_a_b()is const with no side effects, so the call did nothing. Flagged by the rs-agentic review on #15723.Summary
double a, b;andget_a_b(x + base_x, a, b);fromupdate_samples_base().Test plan
test-synchronization-timestamps(static build): 6/6 pass.🤖 Generated by AI