Repository navigation
Stop the react-viewer build printing glyphs Jenkins cannot render - #15774
Merged
AviaAv merged 2 commits intoOct 12, 2026
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Auto-generated review by rs-agentic bot.
The fix is sound — removing non-ASCII characters from both files cleanly resolves the Jenkins charset mangling. Two minor notes inline.
AviaAv
force-pushed
the
librealsense-react-viewer-e2e
branch
from
October 8, 2026 11:08
c2de4ff to
52a045a
Compare
Nir-Az
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins decodes the agent's stdout with a single-byte charset and writes U+FFFD into the stored log, one replacement char per original UTF-8 byte. Nothing viewer-side can recover it, so every non-ASCII character the build prints is permanently garbage in the console:
bundle-for-prod.js— the five progress lines are dropped. The last one was also misleading: read in a CI log, "Run the server" sounds like a server was started, when it only means the files are in place. One line remains, saying why the step exists:The error path loses its emoji too, so the file is pure ASCII and cannot mangle at all.
package.json—vite build --logLevel warnsilences vite's own summary, which is where the remaining???came from (✓and the│column separator). The cost is the per-chunk size table; real warnings and errors still print, and the build is unchanged otherwise.Together these leave zero mangled characters in the install stage.
The underlying charset problem affects every job on these agents, not just this one, and belongs in a DevOps ticket against the agent JVM.
Tracked on: [RSDEV-13683]
🤖 Generated with Claude Code