Skip to content

Stop the react-viewer build printing glyphs Jenkins cannot render - #15774

Merged
AviaAv merged 2 commits into
realsenseai:developmentfrom
AviaAv:librealsense-react-viewer-e2e
Oct 12, 2026
Merged

AviaAv merged 2 commits into
realsenseai:developmentfrom
AviaAv:librealsense-react-viewer-e2e

Conversation

@AviaAv

@AviaAv AviaAv commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Jenkins decodes the agent's stdout with a single-byte charset and writes U+FFFD into the stored log, one replacement char per original UTF-8 byte. Nothing viewer-side can recover it, so every non-ASCII character the build prints is permanently garbage in the console:

???? Bundling React build for production...
???? Copying from: .../dist
???? Copying to:   .../static
??? Build bundled successfully!
???? Run the server - it serves this build automatically.
...
??? 3108 modules transformed.
dist/index.html   0.64 kB ??? gzip: 0.36 kB
??? built in 11.10s

bundle-for-prod.js — the five progress lines are dropped. The last one was also misleading: read in a CI log, "Run the server" sounds like a server was started, when it only means the files are in place. One line remains, saying why the step exists:

The rest-api server now serves the viewer itself, with no separate dev server.

The error path loses its emoji too, so the file is pure ASCII and cannot mangle at all.

package.json — vite build --logLevel warn silences vite's own summary, which is where the remaining ??? came from (✓ and the │ column separator). The cost is the per-chunk size table; real warnings and errors still print, and the build is unchanged otherwise.

Together these leave zero mangled characters in the install stage.

The underlying charset problem affects every job on these agents, not just this one, and belongs in a DevOps ticket against the agent JVM.

Tracked on: [RSDEV-13683]

🤖 Generated with Claude Code

@AviaAv
AviaAv requested a review from Nir-Az October 8, 2026 10:05

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated review by rs-agentic bot.

The fix is sound — removing non-ASCII characters from both files cleanly resolves the Jenkins charset mangling. Two minor notes inline.

@AviaAv
AviaAv force-pushed the librealsense-react-viewer-e2e branch from c2de4ff to 52a045a Compare October 8, 2026 11:08
@AviaAv
AviaAv merged commit 0b58c73 into realsenseai:development Oct 12, 2026
@AviaAv
AviaAv deleted the librealsense-react-viewer-e2e branch October 12, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants