Repository navigation
Allow embedded DPP filters to run with object detection - #15839
Conversation
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
Auto-generated review by rs-agentic bot.
SDK and Viewer changes look clean — pure removal of the mutual-exclusion guards with no dead code left behind. Two notes on the new test file below.
ashrafk93
left a comment
There was a problem hiding this comment.
Tested on a D585 Prototype over USB, FW 7.59.46675.16763, V4L2. Your test gives the same 6 passed / 3 skipped. Depth + color + OD stream together at ~30 fps with decimation, temporal and both, and both filters are measurably active while OD runs, so the feature works on this FW.
Two things worth knowing: over USB the old guard never fired (so this mostly changes the Viewer for USB users, and the open question is D555, see inline), and the new test passes on base as well, see inline. Also, if #15840 merges before this one, nightly D585 will run the old pytest-mutual-exclusions.py and it fails 7/7 there (object doesn't support option Embedded Filter Enabled), so this one should go first.
|
Agreed on order: this should merge before #15840, since it removes pytest-mutual-exclusions.py. |
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
Auto-generated review by rs-agentic bot — synchronize push.
|
Change of plan: #15840 merges first, with a D585 exclude on pytest-mutual-exclusions.py so nightly stays green; this PR will rebase on it and delete that file. |
|
Needs a rebase on #15840 (conflict on |
104f05f to
3cd9cd5
Compare
ashrafk93
left a comment
There was a problem hiding this comment.
Rebuilt the rebased head and ran the test file on a D585 Prototype over USB (FW 7.59.46675): 8 passed, 3 skipped, OD ~30 fps alongside each filter in the streaming test. The rebase only carries #15840's excludes into the deleted file. LGTM; the depth-frame count (also raised by the bot) can be a follow-up.
Overview: The decimation and temporal embedded filters can now run while the object detection stream is active. The SDK and the Viewer no longer block this combination.
Tracked on RSDEV-15374
Why
These filters used to run on the camera DSP, and that clashed with object detection, so the SDK and the Viewer rejected the combination. With FW 7.59 they run on the CPU instead, so the restriction is no longer needed.
Summary
pytest-mutual-exclusions.pywithpytest-perception-embedded-filters.py. It checks that the filters and perception coexist in every order, and a streaming test runs depth + color + object detection with each DPP filter on, asserting that perception frames keep coming and that depth metadata reports the filter as applied. It uses stackeddevice_eachmarkers (the old singledevice_each("D555", "D585")marker only ever picked D555).Test plan
pytest-perception-embedded-filters.pyon D585 Dual RGB (USB), FW 7.59.46675: 8 passed, 3 skipped (improved close range not present over USB)Rebased on #15840 (merged):
pytest-mutual-exclusions.pyis deleted here, and the new test keeps itsdevice_exclude("D585S")(no embedded filters on that camera).🤖 Generated by AI