Skip to content

Allow embedded DPP filters to run with object detection - #15839

Merged
Nir-Az merged 5 commits into
realsenseai:developmentfrom
Nir-Az:dpp-od-coexist
Oct 21, 2026
Merged

Nir-Az merged 5 commits into
realsenseai:developmentfrom
Nir-Az:dpp-od-coexist

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Overview: The decimation and temporal embedded filters can now run while the object detection stream is active. The SDK and the Viewer no longer block this combination.

Tracked on RSDEV-15374

Why

These filters used to run on the camera DSP, and that clashed with object detection, so the SDK and the Viewer rejected the combination. With FW 7.59 they run on the CPU instead, so the restriction is no longer needed.

Summary

  • SDK: removed the checks that reject opening the perception stream while a decimation/temporal filter is enabled, and that reject enabling those filters while perception is open or streaming (DDS activation guard). Over USB the DPP filters only expose their composite option, so these checks only ever fired over DDS.
  • Viewer: the perception Start button and the decimation/temporal filter toggles are no longer disabled because of each other. The other perception gates (color required, GMSL IR channel, decimation read-only while depth streams) are unchanged.
  • Test: replaced pytest-mutual-exclusions.py with pytest-perception-embedded-filters.py. It checks that the filters and perception coexist in every order, and a streaming test runs depth + color + object detection with each DPP filter on, asserting that perception frames keep coming and that depth metadata reports the filter as applied. It uses stacked device_each markers (the old single device_each("D555", "D585") marker only ever picked D555).

Test plan

  • pytest-perception-embedded-filters.py on D585 Dual RGB (USB), FW 7.59.46675: 8 passed, 3 skipped (improved close range not present over USB)
  • Same file on D555 over DDS, FW 7.59.46675: 11 passed
  • Manual: D555 over DDS and USB on FW 7.59.46675 streams depth + color + object detection with decimation, temporal and both; depth metadata confirms each filter is applied
  • Viewer on D585 Dual RGB: object detection runs with DPP filters on at 30 FPS
  • Older D555 FW (pre-7.59) not tested. No FW gate is added, so D555/D585 FW older than 7.59 (DPP on the DSP) may still clash with object detection.

Rebased on #15840 (merged): pytest-mutual-exclusions.py is deleted here, and the new test keeps its device_exclude("D585S") (no embedded filters on that camera).


🤖 Generated by AI

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated review by rs-agentic bot.

SDK and Viewer changes look clean — pure removal of the mutual-exclusion guards with no dead code left behind. Two notes on the new test file below.

@Nir-Az
Nir-Az marked this pull request as ready for review October 20, 2026 11:36
@Nir-Az
Nir-Az requested a review from ashrafk93 October 20, 2026 11:38

@ashrafk93 ashrafk93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a D585 Prototype over USB, FW 7.59.46675.16763, V4L2. Your test gives the same 6 passed / 3 skipped. Depth + color + OD stream together at ~30 fps with decimation, temporal and both, and both filters are measurably active while OD runs, so the feature works on this FW.

Two things worth knowing: over USB the old guard never fired (so this mostly changes the Viewer for USB users, and the open question is D555, see inline), and the new test passes on base as well, see inline. Also, if #15840 merges before this one, nightly D585 will run the old pytest-mutual-exclusions.py and it fails 7/7 there (object doesn't support option Embedded Filter Enabled), so this one should go first.

Comment thread src/ds/d500/d500-object-detection.cpp Resolved
@Nir-Az

Nir-Az commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Agreed on order: this should merge before #15840, since it removes pytest-mutual-exclusions.py.

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated review by rs-agentic bot — synchronize push.

@Nir-Az

Nir-Az commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Change of plan: #15840 merges first, with a D585 exclude on pytest-mutual-exclusions.py so nightly stays green; this PR will rebase on it and delete that file.

@ashrafk93

Copy link
Copy Markdown
Collaborator

Needs a rebase on #15840 (conflict on pytest-mutual-exclusions.py). LGTM once that's in.

@ashrafk93 ashrafk93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuilt the rebased head and ran the test file on a D585 Prototype over USB (FW 7.59.46675): 8 passed, 3 skipped, OD ~30 fps alongside each filter in the streaming test. The rebase only carries #15840's excludes into the deleted file. LGTM; the depth-frame count (also raised by the bot) can be a follow-up.

@Nir-Az
Nir-Az merged commit 6f855ef into realsenseai:development Oct 21, 2026
@Nir-Az
Nir-Az deleted the dpp-od-coexist branch October 21, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants