Skip to content

avoid mem leaks in rs.cpp by taking ownership of callback ptrs - #9762

Merged
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:development
Sep 14, 2021
Merged

maloel merged 1 commit into
realsenseai:developmentfrom
maloel:development

Conversation

@maloel

@maloel maloel commented Sep 13, 2021 •

Copy link
Copy Markdown
Contributor

Addresses #3873 and #4447: potential memory leak in pipeline::start method (callback overloads).

Tracked on [DSO-13704]

@maloel

maloel commented Sep 14, 2021

Copy link
Copy Markdown
Contributor Author

I ran our sample code, and unit-tests, through clang-tidy version 12.0.1.
I failed to reproduce the errors mentioned in the above tickets.
That said, I can understand them in theory -- but am leaving until another complaint comes up as the chances of such leaks is nil.

@maloel
maloel requested a review from Nir-Az September 14, 2021 08:28
@maloel
maloel marked this pull request as ready for review September 14, 2021 08:29

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maloel
maloel merged commit abf60b1 into realsenseai:development Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants