Repository navigation
Remove stale "connection" arg from get_resolved_ip docstring - #4164
Merged
Merged
Conversation
AbstractConnection.get_resolved_ip takes no arguments; it operates on self. The documented `connection` parameter is left over from an earlier signature.
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
AbstractConnection.get_resolved_iptakes no arguments (it operates onself), but its docstring documents aconnectionparameter left over from an earlier signature. This removes the staleArgs:block.Note
Low Risk
Documentation-only change with no runtime or API behavior impact.
Overview
Updates the
get_resolved_ipdocstring onMaintNotificationsAbstractConnectionso it matches the real API: the method only usesself(socket peer name, then DNS onhost/port).Removes the leftover
Args:block that documented aconnectionparameter from an older signature.Reviewed by Cursor Bugbot for commit ee3a8e9. Bugbot is set up for automated code reviews on this repo. Configure here.