Skip to content

test: run the standard suite against an external Redis Enterprise database - #4189

Merged
kiryazovi-redis merged 4 commits into
redis:masterfrom
kiryazovi-redis:fix/re-endpoints-config
Jul 16, 2026
Merged

kiryazovi-redis merged 4 commits into
redis:masterfrom
kiryazovi-redis:fix/re-endpoints-config

Conversation

@kiryazovi-redis

@kiryazovi-redis kiryazovi-redis commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The standard test suite assumes a passwordless Redis reachable on localhost:6379. This change lets the same suite also run against an external / managed Redis Enterprise database - remote host, authentication, and optional TLS - without changing the existing local behaviour.

What changed

  • Opt-in endpoint discovery. When RE_CLUSTER=true, the suite resolves the target database's host, port, username, password and TLS from REDIS_ENDPOINTS_CONFIG_PATH (the same endpoints-config format already consumed by tests/test_scenario) and applies it to --redis-url / --redis-mod-url via a pytest_configure hook. RE_DB_NAME selects a named database (defaults to standalone). When RE_CLUSTER is unset, behaviour is unchanged (localhost:6379, no auth), so the existing local flow is unaffected.
  • skip_if_redis_enterprise on the specs that cannot meaningfully run against a managed Enterprise database (each with an inline rationale):
    • Client-internal / local-only: the localhost handshake-retry tests (test_retry_connect_on_timeout_error, test_connect_with_retries), the hardcoded-localhost from_url single-connection test, the default-localhost CLIENT SETINFO deprecated-params paths, and the timing-sensitive interrupted-command regression.
    • OSS-vs-Enterprise behaviour: CONFIG GET parameter differences (e.g. maxmemory), module CONFIG/FT.CONFIG/INFO-modules shape, CLIENT LIST behind a proxy, SLOWLOG GET field shape, COPY across DB indexes, ACL SETUSER (module ACL specs), FT.DEL, and the RESP3 bytes-keys search result shape.
    • Impractical: BF.SCANDUMP/BF.LOADCHUNK (scandump cursor loop times out on the managed bloom module).

Validation

Ran against a managed Redis Enterprise 8.x database: 694 passed, 428 skipped, 9 previously-failing specs now labelled (the 9 were the Enterprise-specific behaviours listed above). With RE_CLUSTER unset the suite still targets localhost:6379 unchanged.


This change was prepared with AI assistance and reviewed before submission.


Note

Low Risk
Test-only changes; default local CI behavior is unchanged unless RE_CLUSTER is set.

Overview
Adds opt-in targeting of a remote Redis Enterprise database: when RE_CLUSTER=true, pytest_configure builds --redis-url and --redis-mod-url from REDIS_ENDPOINTS_CONFIG_PATH (and RE_DB_NAME, default standalone), including auth and relaxed TLS for rediss. Local runs stay on localhost:6379 when the flag is unset.

Marks additional integration tests with @skip_if_redis_enterprise() and short rationales so the suite can pass against managed Enterprise without false failuresβ€”covering localhost-only connection tests, proxy/admin/ACL/CONFIG differences, cross-DB COPY, bloom scandump timeouts, search FT.DEL/RESP3 shape, and similar gaps.

Reviewed by Cursor Bugbot for commit 54b4652. Bugbot is set up for automated code reviews on this repo. Configure here.

…luster

Read the target database connection (host, port, username, password, TLS)
from REDIS_ENDPOINTS_CONFIG_PATH when RE_CLUSTER=true, and apply it to the
clients the suite builds via --redis-url / --redis-mod-url. RE_DB_NAME selects
a named database (default standalone); when RE_CLUSTER is unset behaviour is
unchanged (localhost:6379, no auth).

Skip the tests that cannot run against a managed Redis Enterprise deployment,
each with an explanatory comment: the LATENCY admin subcommands, CLIENT
NO-EVICT, ACL SETUSER (module ACL specs), COPY across DB indexes, and the
localhost-only CLIENT SETINFO deprecated-params check.
Add skip_if_redis_enterprise to specs that cannot run against a managed
Redis Enterprise deployment, each with a rationale: the config/module-config
shape differences (CONFIG GET maxmemory, module CONFIG, FT.CONFIG, INFO
modules section), and the client-internal/localhost-only tests (CLIENT SETINFO
driver-info variant, the localhost Connection retry test, and the hardcoded
localhost from_url single-connection test).
Based on a full run against a managed Redis Enterprise 8.x database, skip the
specs that fail due to Enterprise-specific behaviour, each with a rationale:
CLIENT LIST proxy behaviour, SLOWLOG GET client_address field, the
timing-sensitive interrupted-command regression, the client-internal localhost
handshake-retry test, BF.SCANDUMP/LOADCHUNK timing out on the bloom module, and
the search module differences (FT.DEL unavailable and the RESP3 bytes-keys
result shape).

@petyaslavova petyaslavova left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Jul 16, 2026
@kiryazovi-redis
kiryazovi-redis merged commit cdda281 into redis:master Jul 16, 2026
368 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants