Repository navigation
test: run the standard suite against an external Redis Enterprise database - #4189
Merged
kiryazovi-redis merged 4 commits intoJul 16, 2026
Merged
Conversation
β¦luster Read the target database connection (host, port, username, password, TLS) from REDIS_ENDPOINTS_CONFIG_PATH when RE_CLUSTER=true, and apply it to the clients the suite builds via --redis-url / --redis-mod-url. RE_DB_NAME selects a named database (default standalone); when RE_CLUSTER is unset behaviour is unchanged (localhost:6379, no auth). Skip the tests that cannot run against a managed Redis Enterprise deployment, each with an explanatory comment: the LATENCY admin subcommands, CLIENT NO-EVICT, ACL SETUSER (module ACL specs), COPY across DB indexes, and the localhost-only CLIENT SETINFO deprecated-params check.
Add skip_if_redis_enterprise to specs that cannot run against a managed Redis Enterprise deployment, each with a rationale: the config/module-config shape differences (CONFIG GET maxmemory, module CONFIG, FT.CONFIG, INFO modules section), and the client-internal/localhost-only tests (CLIENT SETINFO driver-info variant, the localhost Connection retry test, and the hardcoded localhost from_url single-connection test).
Based on a full run against a managed Redis Enterprise 8.x database, skip the specs that fail due to Enterprise-specific behaviour, each with a rationale: CLIENT LIST proxy behaviour, SLOWLOG GET client_address field, the timing-sensitive interrupted-command regression, the client-internal localhost handshake-retry test, BF.SCANDUMP/LOADCHUNK timing out on the bloom module, and the search module differences (FT.DEL unavailable and the RESP3 bytes-keys result shape).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The standard test suite assumes a passwordless Redis reachable on
localhost:6379. This change lets the same suite also run against an external / managed Redis Enterprise database - remote host, authentication, and optional TLS - without changing the existing local behaviour.What changed
RE_CLUSTER=true, the suite resolves the target database's host, port, username, password and TLS fromREDIS_ENDPOINTS_CONFIG_PATH(the same endpoints-config format already consumed bytests/test_scenario) and applies it to--redis-url/--redis-mod-urlvia apytest_configurehook.RE_DB_NAMEselects a named database (defaults tostandalone). WhenRE_CLUSTERis unset, behaviour is unchanged (localhost:6379, no auth), so the existing local flow is unaffected.skip_if_redis_enterpriseon the specs that cannot meaningfully run against a managed Enterprise database (each with an inline rationale):test_retry_connect_on_timeout_error,test_connect_with_retries), the hardcoded-localhostfrom_urlsingle-connection test, the default-localhostCLIENT SETINFOdeprecated-params paths, and the timing-sensitive interrupted-command regression.CONFIG GETparameter differences (e.g.maxmemory), moduleCONFIG/FT.CONFIG/INFO-modules shape,CLIENT LISTbehind a proxy,SLOWLOG GETfield shape,COPYacross DB indexes,ACL SETUSER(module ACL specs),FT.DEL, and the RESP3 bytes-keys search result shape.BF.SCANDUMP/BF.LOADCHUNK(scandump cursor loop times out on the managed bloom module).Validation
Ran against a managed Redis Enterprise 8.x database: 694 passed, 428 skipped, 9 previously-failing specs now labelled (the 9 were the Enterprise-specific behaviours listed above). With
RE_CLUSTERunset the suite still targetslocalhost:6379unchanged.This change was prepared with AI assistance and reviewed before submission.
Note
Low Risk
Test-only changes; default local CI behavior is unchanged unless
RE_CLUSTERis set.Overview
Adds opt-in targeting of a remote Redis Enterprise database: when
RE_CLUSTER=true,pytest_configurebuilds--redis-urland--redis-mod-urlfromREDIS_ENDPOINTS_CONFIG_PATH(andRE_DB_NAME, defaultstandalone), including auth and relaxed TLS forrediss. Local runs stay onlocalhost:6379when the flag is unset.Marks additional integration tests with
@skip_if_redis_enterprise()and short rationales so the suite can pass against managed Enterprise without false failuresβcovering localhost-only connection tests, proxy/admin/ACL/CONFIG differences, cross-DBCOPY, bloom scandump timeouts, searchFT.DEL/RESP3 shape, and similar gaps.Reviewed by Cursor Bugbot for commit 54b4652. Bugbot is set up for automated code reviews on this repo. Configure here.