Skip to content

Added support for CELL_SIZE argument for CMS.INITBYDIM and CMS.INITBYPROB - #4341

Merged
vladvildanov merged 5 commits into
masterfrom
vv-cell-size
Sep 28, 2026
Merged

vladvildanov merged 5 commits into
masterfrom
vv-cell-size

Conversation

@vladvildanov

@vladvildanov vladvildanov commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Description of change

Please provide a description of the change here.

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.


Note

Low Risk
Backward-compatible optional API and optional INFO field; behavior changes only when callers pass cell_size on supported servers.

Overview
Adds optional cell_size support for Count-Min Sketch creation via CMS.INITBYDIM and CMS.INITBYPROB, sending the CELL_SIZE argument when set (1, 2, 4, or 8 bytes; server default 4). CMS.INFO parsing now exposes cell_size when the server returns it; older RedisBloom builds omit the field.

CI integration tests now include Redis 8.12.0 (custom unstable image) and 8.10.2 in the matrix, replacing the previous 8.10 mapping. Sync and async test_cms_cell_size coverage is gated on RedisBloom β‰₯ 8.11.0.

Reviewed by Cursor Bugbot for commit 5f89125. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-09-25T07:58:38.376354Z 5f89125 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8125ebb700

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/integration.yaml Resolved
@vladvildanov
vladvildanov merged commit d122cfc into master Sep 28, 2026
389 of 394 checks passed
@vladvildanov
vladvildanov deleted the vv-cell-size branch September 28, 2026 06:50
@petyaslavova petyaslavova added the feature New feature label Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants