Repository navigation
Added support for CELL_SIZE argument for CMS.INITBYDIM and CMS.INITBYPROB - #4341
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8125ebb700
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Please provide a description of the change here.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Note
Low Risk
Backward-compatible optional API and optional INFO field; behavior changes only when callers pass
cell_sizeon supported servers.Overview
Adds optional
cell_sizesupport for Count-Min Sketch creation viaCMS.INITBYDIMandCMS.INITBYPROB, sending theCELL_SIZEargument when set (1, 2, 4, or 8 bytes; server default 4).CMS.INFOparsing now exposescell_sizewhen the server returns it; older RedisBloom builds omit the field.CI integration tests now include Redis 8.12.0 (custom unstable image) and 8.10.2 in the matrix, replacing the previous 8.10 mapping. Sync and async
test_cms_cell_sizecoverage is gated on RedisBloom β₯ 8.11.0.Reviewed by Cursor Bugbot for commit 5f89125. Bugbot is set up for automated code reviews on this repo. Configure here.