Skip to content

fix: preserve false tsconfig option - #1065

Merged
sxzz merged 1 commit into
rolldown:mainfrom
Masutayunikon:fix/preserve-tsconfig-false
Sep 6, 2026
Merged

sxzz merged 1 commit into
rolldown:mainfrom
Masutayunikon:fix/preserve-tsconfig-false

Conversation

@Masutayunikon

Copy link
Copy Markdown
Contributor

AI usage

AI usage

  • No AI was used in this PR.
  • AI was used: ChatGPT + GPT 5.6 Luna
    • I have carefully reviewed the AI-generated content myself.

Description

Preserve the false value of the tsconfig option when passing it to Rolldown.

tsconfig accepts both false and a string path. The current implementation uses the || operator:

tsconfig: tsconfig || undefined,

When tsconfig is explicitly set to false, it is converted to undefined. This prevents Rolldown from receiving tsconfig: false and causes it to fall back to automatic tsconfig resolution.

This PR changes the fallback to nullish coalescing:

tsconfig: tsconfig ?? undefined,

This preserves both supported values while still handling undefined correctly.

The issue was reproduced in a NuxtHub project using tsconfig: false.

Linked Issues

N/A

Additional context

The bug was reproduced with a NuxtHub project and the fix was validated by running the project successfully with tsconfig: false.

A minimal reproduction is available here:

https://github.com/Masutayunikon/Fankarr-Bridge

Copilot AI lite review requested due to automatic review settings September 5, 2026 20:02
@netlify

netlify Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

βœ… Deploy Preview for tsdown-main ready!

Name Link
πŸ”¨ Latest commit 7935f25
πŸ” Latest deploy log https://app.netlify.com/projects/tsdown-main/deploys/6a9c75705367a00008911499
😎 Deploy Preview https://deploy-preview-1065--tsdown-main.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
πŸ€– Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown@1065 -D
npm i https://pkg.pr.new/rolldown/tsdown@1065 -D
yarn add https://pkg.pr.new/rolldown/tsdown@1065.tgz -D

create-tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1065 -D
npm i https://pkg.pr.new/rolldown/tsdown/create-tsdown@1065 -D
yarn add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1065.tgz -D

@tsdown/css

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1065 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1065 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1065.tgz -D

@tsdown/exe

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1065 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1065 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1065.tgz -D

tsdown-migrate

pnpm add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1065 -D
npm i https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1065 -D
yarn add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1065.tgz -D

commit: 7935f25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟑 Changes recommended

A small regression test should be added to assert that tsconfig: false is actually forwarded into Rolldown input options to prevent this bug from recurring.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR fixes propagation of the tsconfig option into Rolldown input options so that an explicit false value is preserved (rather than being coerced to undefined), aligning the build behavior with the documented option semantics.

Changes:

  • Replace tsconfig || undefined with tsconfig ?? undefined when building Rolldown input options.
  • Ensure tsconfig: false can be forwarded to Rolldown to disable automatic tsconfig resolution.
File summaries
File Description
src/features/rolldown.ts Preserves explicit false for the tsconfig option when creating Rolldown input options.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/features/rolldown.ts Resolved
@sxzz
sxzz merged commit 407f84b into rolldown:main Sep 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants