Repository navigation
fix: downgrade rolldown-plugin-dts to 0.28 to restore TypeScript 7.0 support - #1107
Merged
Merged
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency rollback, lockfile, schema, and test configuration are consistent, with no blocking issues identified.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
This PR restores TypeScript 7.0 support in tsdown by rolling back rolldown-plugin-dts to the 0.28 release line, addressing the patch-release regression reported in #1106.
Changes:
- Downgrades
rolldown-plugin-dtsto^0.28.8and updates the lockfile. - Restores the 0.28 declaration-option schema.
- Updates the project-reference test to use
dts.build.
| File | Description |
|---|---|
tests/issues.test.ts |
Restores the 0.28-compatible build option. |
schema.json |
Aligns declaration options with the downgraded plugin. |
pnpm-workspace.yaml |
Sets the plugin dependency range to ^0.28.8. |
pnpm-lock.yaml |
Locks plugin 0.28.8 and its peer metadata. |
Review effort: Balanced
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.23.2 bumped
rolldown-plugin-dtsfrom^0.28.7to^0.29.0-beta.2. In 0.29, thetsgogenerator is only auto-selected whentypescript/asyncexposesProgram.prototype.getDeclarationEmit, which TypeScript 7.1 beta has but 7.0.x does not (7.0 only shipstypescript/unstable/async). With TypeScript 7.0 installed and noisolatedDeclarations, the plugin falls back totscand then throws because TypeScript >= 7 has no classic API.This PR downgrades
rolldown-plugin-dtsback to^0.28.8for a patch release, and reverts the related changes:tests/issues.test.ts:dts: { tsc: { build: true } }->dts: { build: true }(0.28 option shape)schema.json: regenerated from the 0.28 typesUpgrading to 0.29 is a breaking change for users (drops TypeScript 7.0, moves
build/vue/ etc. underdts.tsc), so it should land in a minor release instead.Verified that a minimal project with
typescript@7.0.2builds withrolldown-plugin-dts@0.28.8and fails with the reported error on0.29.0-beta.2.Closes #1106