Repository navigation
perf: use tinyps in hooks - #1112
Merged
Merged
Conversation
This switches from `tree-kill` (CJS) to `tinyps` (ESM). It is slightly larger (a couple of KB) but replaces quite a lot of very similar process management packages, so will de-dupe better over time. Note the `catch` is because `killTree` will throw if it doesn't have permission, for example.
β Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
π’ Approval recommended
No active review issues block the switch to tinyps for process-tree cleanup.
No open issues π
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Replaces CommonJS-based tree-kill with ESM-based tinyps for process-tree cleanup in tsdownβs success hooks.
Changes:
- Uses
killTreeto terminate the success-hook process tree on abort and logs rejected cleanup errors. - Updates the production dependency, workspace catalog, and lockfile to
tinyps0.5.1.
| File | Description |
|---|---|
src/βfeatures/βhooks.ts |
Switches to killTree and adds rejection logging. |
pnpm-workspace.yaml |
Replaces the catalog entry with tinyps ^0.5.1. |
pnpm-lock.yaml |
Records tinyps 0.5.1 and removes tree-kill. |
package.json |
Replaces the production dependency with tinyps. |
Review effort: Balanced
sxzz
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches from
tree-kill(CJS) totinyps(ESM). It is slightlylarger (a couple of KB) but replaces quite a lot of very similar process
management packages, so will de-dupe better over time.
Note the
catchis becausekillTreewill throw if it doesn't havepermission, for example.
AI usage
Linked Issues
N/A
Additional context
N/A