Skip to content

perf: use tinyps in hooks - #1112

Merged
sxzz merged 1 commit into
rolldown:mainfrom
43081j:jg/treehugging
Oct 29, 2026
Merged

sxzz merged 1 commit into
rolldown:mainfrom
43081j:jg/treehugging

Conversation

@43081j

@43081j 43081j commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

This switches from tree-kill (CJS) to tinyps (ESM). It is slightly
larger (a couple of KB) but replaces quite a lot of very similar process
management packages, so will de-dupe better over time.

Note the catch is because killTree will throw if it doesn't have
permission, for example.

AI usage

  • No AI was used in this PR.
  • AI was used:
    • I have carefully reviewed the AI-generated content myself.

Linked Issues

N/A

Additional context

N/A

This switches from `tree-kill` (CJS) to `tinyps` (ESM). It is slightly
larger (a couple of KB) but replaces quite a lot of very similar process
management packages, so will de-dupe better over time.

Note the `catch` is because `killTree` will throw if it doesn't have
permission, for example.
Copilot AI balanced review requested due to automatic review settings October 29, 2026 11:18
@netlify

netlify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

βœ… Deploy Preview for tsdown-main ready!

Name Link
πŸ”¨ Latest commit 124e70e
πŸ” Latest deploy log https://app.netlify.com/projects/tsdown-main/deploys/6ae32b99eee79578bc7868c0
😎 Deploy Preview https://deploy-preview-1112--tsdown-main.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
πŸ€– Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Oct 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown@1112 -D
npm i https://pkg.pr.new/rolldown/tsdown@1112 -D
yarn add https://pkg.pr.new/rolldown/tsdown@1112.tgz -D

create-tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1112 -D
npm i https://pkg.pr.new/rolldown/tsdown/create-tsdown@1112 -D
yarn add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1112.tgz -D

@tsdown/css

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1112 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1112 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1112.tgz -D

@tsdown/exe

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1112 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1112 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1112.tgz -D

tsdown-migrate

pnpm add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1112 -D
npm i https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1112 -D
yarn add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1112.tgz -D

commit: 124e70e

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedtinyps@​0.5.11001009889100

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Approval recommended

No active review issues block the switch to tinyps for process-tree cleanup.

No open issues πŸŽ‰

1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Replaces CommonJS-based tree-kill with ESM-based tinyps for process-tree cleanup in tsdown’s success hooks.

Changes:

  • Uses killTree to terminate the success-hook process tree on abort and logs rejected cleanup errors.
  • Updates the production dependency, workspace catalog, and lockfile to tinyps 0.5.1.
File Description
src/​features/​hooks.ts Switches to killTree and adds rejection logging.
pnpm-workspace.yaml Replaces the catalog entry with tinyps ^0.5.1.
pnpm-lock.yaml Records tinyps 0.5.1 and removes tree-kill.
package.json Replaces the production dependency with tinyps.

Review effort: Balanced

@sxzz sxzz changed the title feat: use tinyps in hooks perf: use tinyps in hooks Oct 29, 2026
@sxzz
sxzz merged commit f925e52 into rolldown:main Oct 29, 2026
16 checks passed
@43081j
43081j deleted the jg/treehugging branch October 29, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants