Repository navigation
Ignore annotations no longer on the classpath in ExtractAPI - #25889
Merged
Merged
Conversation
Contributor
|
Actually, this PR https://github.com/scala/scala3/pull/12592/changes seems to contain a reference to how to write a compilation test excluding something from the classpath at a desired stage |
Contributor
Author
|
Nice find! I added a test, and confirmed that the test fails without the fix |
prolativ
approved these changes
Apr 21, 2026
SolalPirelli
enabled auto-merge (squash)
April 21, 2026 13:00
mbovel
pushed a commit
to mbovel/dotty
that referenced
this pull request
May 4, 2026
) Fixes scala#25722 ## How much have you relied on LLM-based tools in this contribution? Not at all ## How was the solution tested? Automated test
bishabosha
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 5, 2026
) Fixes scala#25722 ## How much have you relied on LLM-based tools in this contribution? Not at all ## How was the solution tested? Automated test
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Jul 8, 2026
) Fixes scala#25722 ## How much have you relied on LLM-based tools in this contribution? Not at all ## How was the solution tested? Automated test [Cherry-picked 5532d08][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25722
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
Automated test
Manual tests because writing automated tests is impractical, described below (in detail)See the issue, it requires compiling some Java code, then manipulating the JAR to remove one classfile...