Skip to content

Ignore annotations no longer on the classpath in ExtractAPI - #25889

Merged
SolalPirelli merged 2 commits into
scala:mainfrom
dotty-staging:solal/grrrrr
Apr 21, 2026
Merged

SolalPirelli merged 2 commits into
scala:mainfrom
dotty-staging:solal/grrrrr

Conversation

@SolalPirelli

@SolalPirelli SolalPirelli commented Apr 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #25722

How much have you relied on LLM-based tools in this contribution?

Not at all

How was the solution tested?

Automated test

Manual tests because writing automated tests is impractical, described below (in detail)

See the issue, it requires compiling some Java code, then manipulating the JAR to remove one classfile...

@SolalPirelli
SolalPirelli requested a review from prolativ April 21, 2026 11:11
@prolativ

Copy link
Copy Markdown
Contributor

Actually, this PR https://github.com/scala/scala3/pull/12592/changes seems to contain a reference to how to write a compilation test excluding something from the classpath at a desired stage

@SolalPirelli

Copy link
Copy Markdown
Contributor Author

Nice find! I added a test, and confirmed that the test fails without the fix

@SolalPirelli
SolalPirelli enabled auto-merge (squash) April 21, 2026 13:00
@SolalPirelli
SolalPirelli merged commit 5532d08 into scala:main Apr 21, 2026
45 checks passed
@SolalPirelli
SolalPirelli deleted the solal/grrrrr branch April 21, 2026 13:22
mbovel pushed a commit to mbovel/dotty that referenced this pull request May 4, 2026
)

Fixes scala#25722

## How much have you relied on LLM-based tools in this contribution?

Not at all

## How was the solution tested?

Automated test
@WojciechMazur WojciechMazur added this to the 3.9.0 milestone May 26, 2026
bishabosha pushed a commit to dotty-staging/dotty that referenced this pull request Jun 5, 2026
)

Fixes scala#25722

## How much have you relied on LLM-based tools in this contribution?

Not at all

## How was the solution tested?

Automated test
tgodzik added a commit to scala/scala3-lts that referenced this pull request Jul 8, 2026
)

Fixes scala#25722

## How much have you relied on LLM-based tools in this contribution?

Not at all

## How was the solution tested?

Automated test
[Cherry-picked 5532d08][modified]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Cannot extend non-static Java inner interface

3 participants