Skip to content

Math (5): filled in @param, @tparam, and @return tags that were missed last time - #26123

Merged
SolalPirelli merged 2 commits into
scala:mainfrom
artimahub:scaladoc-tags-math-cleanup
Jun 11, 2026
Merged

SolalPirelli merged 2 commits into
scala:mainfrom
artimahub:scaladoc-tags-math-cleanup

Conversation

@bvenners

Copy link
Copy Markdown
Contributor

As a next step in improving the Scaladoc documentation for the Scala 3 standard library, this PR fills in @param, @tparam, and @return tags for scala.math that were missed in the previous batch of PRs. I'm submitting it as a draft PR so to get CI to run on it, to see if it breaks anything, and to start getting feedback. We automated the generation of these changes and are starting to review them. We will review them all before making the PR non-draft. Please let me know if you see anything specific that you think could be improved.

@cheeseng cheeseng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bvenners
bvenners force-pushed the scaladoc-tags-math-cleanup branch 3 times, most recently from a2b133f to 6c6e324 Compare June 1, 2026 05:18
@bvenners
bvenners marked this pull request as ready for review June 1, 2026 05:19
@bvenners
bvenners requested a review from a team as a code owner June 1, 2026 05:19
@cheeseng

cheeseng commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The related CI run seems to be stuck, I tried it run the same command:

sbt scala-library-sjs/mimaReportBinaryIssues

in the same branch it seems to be ok, @SethTisue can we try to rerun the related CI run?

@SethTisue SethTisue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI likes it; I hit "re-run" on the failing job; ping me again if it fails again

@bvenners
bvenners force-pushed the scaladoc-tags-math-cleanup branch from 6c6e324 to 5decda1 Compare June 10, 2026 04:10
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@SolalPirelli
SolalPirelli merged commit 0c4b570 into scala:main Jun 11, 2026
45 checks passed
@WojciechMazur WojciechMazur added this to the 3.10.0 milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants