Skip to content

Use \n for missing methods patch - #26133

Merged
mbovel merged 1 commit into
scala:mainfrom
dotty-staging:solal/ci-win
May 21, 2026
Merged

mbovel merged 1 commit into
scala:mainfrom
dotty-staging:solal/ci-win

Conversation

@SolalPirelli

@SolalPirelli SolalPirelli commented May 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #26131

As already done by the "insert missing cases" action

How much have you relied on LLM-based tools in this contribution?

Not at all

How was the solution tested?

Covered by existing tests (this is a refactoring)

[test_windows_full]

@som-snytt

Copy link
Copy Markdown
Contributor

Usually I would fix tests by normalizing output. App output is in the local convention.

@SolalPirelli

Copy link
Copy Markdown
Contributor Author

Usually I would fix tests by normalizing output. App output is in the local convention.

So would I but that's not how existing tests / code actions do it.

@SolalPirelli
SolalPirelli requested a review from mbovel May 21, 2026 11:30
@mbovel
mbovel enabled auto-merge (squash) May 21, 2026 11:31
@mbovel
mbovel merged commit 9397400 into scala:main May 21, 2026
112 of 114 checks passed
@mbovel
mbovel deleted the solal/ci-win branch May 21, 2026 12:07
bishabosha pushed a commit to dotty-staging/dotty that referenced this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows tests failing

3 participants