Skip to content

Fix false unused-var warning on self-assignment reads (#26620) - #26635

Merged
Gedochao merged 3 commits into
scala:mainfrom
Gedochao:fix/26620
Jul 31, 2026
Merged

Gedochao merged 3 commits into
scala:mainfrom
Gedochao:fix/26620

Conversation

@Gedochao

Copy link
Copy Markdown
Contributor

Fixes #26620

Have you relied on LLM-based tools in this contribution?

Yes, and I checked the output by running it against the issue's reproducer + a couple more cases

How was the solution tested?

New automated tests (including the issue's reproducer)

@Gedochao
Gedochao requested review from som-snytt and tgodzik July 28, 2026 09:02
@Gedochao
Gedochao marked this pull request as ready for review July 28, 2026 09:27
@Gedochao Gedochao added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 28, 2026
@Gedochao Gedochao added this to the 3.9.0 milestone Jul 28, 2026
@Gedochao
Gedochao requested a review from tgodzik July 29, 2026 08:22

@tgodzik tgodzik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao

Copy link
Copy Markdown
Contributor Author

(rebased)

@Gedochao
Gedochao enabled auto-merge (squash) July 31, 2026 08:25
@Gedochao
Gedochao disabled auto-merge July 31, 2026 08:57
@Gedochao
Gedochao requested a review from Florian3k July 31, 2026 09:18
@Gedochao
Gedochao merged commit 9089bf5 into scala:main Jul 31, 2026
59 checks passed
@Gedochao
Gedochao deleted the fix/26620 branch July 31, 2026 11:30
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Aug 3, 2026
WojciechMazur added a commit that referenced this pull request Aug 7, 2026
…)" to 3.9.0 (#26693)

Backports #26635 to the 3.9.0-RC5.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:done This PR was successfully backported.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid unused warning

4 participants