Repository navigation
Do not emit a SYNCHRONIZED method for Outer.this.synchronized calls - #26998
Merged
Merged
Conversation
SolalPirelli
commented
Sep 8, 2026
SolalPirelli
force-pushed
the
solal/outer-synchronized
branch
from
September 8, 2026 09:02
3156a78 to
6e5a4a1
Compare
SolalPirelli
commented
Sep 8, 2026
| tailrec-synchronized.scala | ||
| tailrec.scala | ||
| traitParams.scala | ||
| outer-synchronized.scala |
Contributor
Author
There was a problem hiding this comment.
cc @anatoliykmetyuk the new test checks that some methods are transformed from an explicit synchronized call to a synchronized method, it seems scoverage breaks that transformation, presumably because it inserts counters before or after the synchronized block
alexarchambault
pushed a commit
to plasmon-scala/scala3
that referenced
this pull request
Nov 4, 2026
…scala#26998) Reported by @natsukagami offline. Regression from scala#26697 ## Have you relied on LLM-based tools in this contribution? No ## How was the solution tested? New automated tests (including the issue's reproducer, if applicable) [Cherry-picked 07fb189][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @natsukagami offline. Regression from #26697
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)