Repository navigation
Parser: do not create empty integer literals - #27126
Merged
SolalPirelli merged 2 commits intoSep 22, 2026
Merged
Conversation
SolalPirelli
force-pushed
the
solal/highlight-broken-lit
branch
from
September 22, 2026 08:23
806a496 to
439a5eb
Compare
SolalPirelli
force-pushed
the
solal/highlight-broken-lit
branch
from
September 22, 2026 08:56
439a5eb to
960e8c1
Compare
som-snytt
approved these changes
Sep 22, 2026
som-snytt
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I checked that - 0x. doesn't throw when warning and patching the span.
| val d = digits | ||
| if d.isEmpty then | ||
| syntaxError(IllegalLiteral(), start) | ||
| Literal(Constant.fromValue(null)) |
Contributor
There was a problem hiding this comment.
What is the difference between EmptyTree and a fabrication?
Contributor
Author
There was a problem hiding this comment.
I used the same return value already used elsewhere in the function to indicate trouble. I don't have any particular opinion on what it should be ^^'
Contributor
There was a problem hiding this comment.
It has the advantage of being totally lit!
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27122
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)