Repository navigation
Backport "Treat IINC to parameter locals as a write" to 3.10.1 - #27544
Merged
Merged
Conversation
The inliner re-uses an existing local for a parameter of the callee, unless the callee writes to it. An IINC write was not detected. Port of scala/scala#11299. Here we have an integration test instead of a unit test. On the Scala 2 side, the unit test crafts a method that uses IINC (which scalac never emits) and then invokes the inliner. But here we currently have no test infra to invoke the inliner manually. LLM-assisted (Claude Code). ## Have you relied on LLM-based tools in this contribution? Yes Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> [Cherry-picked 9f78b66]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #27316 to the 3.10.1-RC2.
PR submitted by the release tooling.