Repository navigation
remove need for channel_as_last_axis decorator in skimage.filters - #5584
Merged
Merged
Conversation
TST: expand difference_of_gaussian tests to include channel_axis
rfezzani
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the need for the
channel_as_last_axisdecorator utility for functions in theskimage.filtersmodule. This decorator allowed existing functions that assumed channels along the last axis to work without modification. However, ideally we will replace this decorator with native support for arbitrary channel position in each function (with possible exception of cases where it would substantially increase the code complexity).This PR does not introduce any change to existing behavior. Some new tests involving
channel_axiswere added to an existingdifference_of_gaussiantest function.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.