Skip to content

minor: update pypi tag - #2463

Merged
zhyncs merged 1 commit into
mainfrom
zhyncs/tag
Dec 12, 2024
Merged

zhyncs merged 1 commit into
mainfrom
zhyncs/tag

Conversation

@zhyncs

@zhyncs zhyncs commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs
zhyncs merged commit dedaf8c into main Dec 12, 2024
@zhyncs
zhyncs deleted the zhyncs/tag branch December 12, 2024 07:21
Comment thread sgl-kernel/setup.py
wheel_dir = Path("dist")
old_wheel = next(wheel_dir.glob("*.whl"))
new_wheel = wheel_dir / old_wheel.name.replace(
"linux_x86_64", "manylinux2014_x86_64"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ByronHsu I believe we should do the same thing for the router wheel as well. Today I noticed that pip doesn't recognize the wheel arch (linux_x86_64) for mariner and tries to build from source. So I had to install it manually.

timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants