⭐ Football Update: sgl project/sglang/pull/

merrymercy · 2026-08-31T08:30:25Z

Motivation

Close Rust/Python sampling parity gaps and make positional wire-schema drift fail in Python unit tests. This is PR 3 of 4 in stack #37223.

Modifications

Normalize empty grammar strings to unset, matching Python.
Include structural_tag in grammar mutual exclusion and align beam validation order.
Give custom_params the same bounded JSON shape as the Python type instead of accepting arbitrary JSON.
Add Rust regression coverage for those parity fixes.
Add Python-importing lockstep tests for SamplingParams and TokenizedGenerateReqInput; the latter permits only a defaulted Python suffix beyond the Rust-emitted prefix.

Test plan

cargo test --manifest-path rust/sglang-server/Cargo.toml --lib (251 passed)
cargo test --manifest-path rust/sglang-mm/Cargo.toml --lib (31 passed)
cargo clippy --manifest-path rust/sglang-server/Cargo.toml --lib --tests -- -D warnings
Rustfmt, Ruff targeted checks, Isort, and Python bytecode compilation
Focused registered tests, including both lockstep files, are triggered in PR comments.

Stack

1/4: [Rust] Split and rename embedded server components #37220
2/4: [Rust] Derive server address and accept signed env values #37221
3/4: this PR
4/4: [Rust] Simplify request defaults and document batch header ABI #37226

CI States

Latest PR Test (Base): 🚫 Run #33430993111
Latest PR Test (Extra): 🚫 Run #33430992822
Latest PR Test (AMD ROCm 7.2): 🚫 Run #33430993191

…at template helpers

…cheduler intake helpers

…t server integration package

…modal integration

…aunch configuration helpers

…imodal terminology

…l and sampling layout

…st-only facade exports

…multimodal terminology

…dress and accept signed env values

…nd wire schemas

merrymercy · 2026-08-31T08:31:18Z

/rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py

merrymercy · 2026-08-31T08:31:20Z

/rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py

github-actions · 2026-08-31T08:31:42Z

Results for /rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py:

🚀 ubuntu-latest (1 test): ❌ View workflow run

cd test/ && python3 registered/rust/test_run_rust_tests.py

🚀 1-gpu-5090 (1 test): ❌ View workflow run

cd test/ && python3 registered/core/test_srt_endpoint.py

🚀 1-gpu-h100 (2 tests): ❌ View workflow run

cd test/ && python3 registered/vlm/test_rust_native_mm_e2e.py
cd test/ && python3 registered/vlm/test_rust_native_mm_mmmu.py

github-actions · 2026-08-31T08:31:47Z

Results for /rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py:

🚀 1-gpu-h100 (1 test): ❌ View workflow run

cd test/ && python3 registered/unit/managers/test_io_struct.py

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/unit/sampling/test_sampling_params.py

…dules

merrymercy · 2026-08-31T08:42:00Z

/rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py

merrymercy · 2026-08-31T08:42:00Z

/rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py

github-actions · 2026-08-31T08:42:25Z

Results for /rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py:

🚀 1-gpu-h100 (1 test): ❌ View workflow run

cd test/ && python3 registered/unit/managers/test_io_struct.py

🚀 ubuntu-latest (1 test): ❌ View workflow run

cd test/ && python3 registered/unit/sampling/test_sampling_params.py

github-actions · 2026-08-31T08:42:25Z

Results for /rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py:

🚀 ubuntu-latest (1 test): ❌ View workflow run

cd test/ && python3 registered/rust/test_run_rust_tests.py

🚀 1-gpu-5090 (1 test): ❌ View workflow run

cd test/ && python3 registered/core/test_srt_endpoint.py

🚀 1-gpu-h100 (2 tests): ❌ View workflow run

cd test/ && python3 registered/vlm/test_rust_native_mm_e2e.py
cd test/ && python3 registered/vlm/test_rust_native_mm_mmmu.py

…helpers

merrymercy · 2026-08-31T08:45:15Z

/rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py

merrymercy · 2026-08-31T08:45:15Z

/rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py

github-actions · 2026-08-31T08:45:37Z

Results for /rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py:

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/rust/test_run_rust_tests.py

🚀 1-gpu-5090 (1 test): ❌ View workflow run

cd test/ && python3 registered/core/test_srt_endpoint.py

🚀 1-gpu-h100 (2 tests): ❌ View workflow run

cd test/ && python3 registered/vlm/test_rust_native_mm_e2e.py
cd test/ && python3 registered/vlm/test_rust_native_mm_mmmu.py

github-actions · 2026-08-31T08:45:38Z

Results for /rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py:

🚀 1-gpu-h100 (1 test): ❌ View workflow run

cd test/ && python3 registered/unit/managers/test_io_struct.py

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/unit/sampling/test_sampling_params.py

merrymercy

approve

merrymercy

approve

…ers precisely

merrymercy · 2026-08-31T09:10:02Z

/rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py

merrymercy · 2026-08-31T09:10:02Z

/rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py

github-actions · 2026-08-31T09:10:29Z

Results for /rerun-test test/registered/unit/managers/test_io_struct.py test/registered/unit/sampling/test_sampling_params.py:

🚀 1-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/unit/managers/test_io_struct.py

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/unit/sampling/test_sampling_params.py

github-actions · 2026-08-31T09:10:29Z

Results for /rerun-test test/registered/rust/test_run_rust_tests.py test/registered/core/test_srt_endpoint.py test/registered/vlm/test_rust_native_mm_e2e.py test/registered/vlm/test_rust_native_mm_mmmu.py:

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/rust/test_run_rust_tests.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/core/test_srt_endpoint.py

🚀 1-gpu-h100 (2 tests): ✅ View workflow run

cd test/ && python3 registered/vlm/test_rust_native_mm_e2e.py
cd test/ && python3 registered/vlm/test_rust_native_mm_mmmu.py

…37222)

merrymercy added 11 commits August 31, 2026 01:29

rust-server-cleanup(template-split,non_mechanical_provable): split ch…

347bf8d

…at template helpers

rust-server-cleanup(scheduler-split,non_mechanical_provable): split s…

46ba4b8

…cheduler intake helpers

rust-server-cleanup(python-package,non_mechanical_provable): move rus…

faaf810

…t server integration package

rust-server-cleanup(mm-module,non_mechanical_provable): extract multi…

dcaea4e

…modal integration

rust-server-cleanup(config-module,non_mechanical_provable): extract l…

f72a802

…aunch configuration helpers

rust-server-cleanup(mm-naming,non_mechanical_provable): use Rust mult…

5c08ff0

…imodal terminology

rust-server-cleanup(style,non_mechanical_provable): clarify multimoda…

f86705b

…l and sampling layout

rust-server-cleanup(template-lints,non_mechanical_provable): scope te…

d89d6e6

…st-only facade exports

rust-server-cleanup(mm-test-names,non_mechanical_provable): use Rust …

678eaa1

…multimodal terminology

rust-server-cleanup(config,non_mechanical_provable): derive listen ad…

fecdde1

…dress and accept signed env values

rust-server-cleanup(parity,non_mechanical_provable): align sampling a…

b3c9b70

…nd wire schemas

merrymercy mentioned this pull request Aug 31, 2026

[Rust] Split and rename embedded server components #37220

Merged

merrymercy changed the title ~~rust-server-cleanup(parity,non_mechanical_provable): align sampling and wire schemas~~ [Rust] Keep sampling and scheduler wire schemas in sync Aug 31, 2026

merrymercy mentioned this pull request Aug 31, 2026

[Rust] Derive server address and accept signed env values #37221

Merged

merrymercy added 3 commits August 31, 2026 01:41

rust-server-cleanup(imports,non_mechanical_provable): use concrete mo…

1915a79

…dules

Merge updated rust-server-cleanup-1-structure

c3307cf

Merge updated rust-server-cleanup-2-config

c9cdf43

merrymercy added the run-ci CI: run the baseline test suite on this PR label Aug 31, 2026

merrymercy added 2 commits August 31, 2026 01:44

rust-server-cleanup(utils,non_mechanical_provable): extract boundary …

976aa5c

…helpers

Merge updated rust-server-cleanup-2-config

c5aca9e

merrymercy mentioned this pull request Aug 31, 2026

[Rust] Simplify request defaults and document batch header ABI #37226

Merged

merrymercy commented Aug 31, 2026

View reviewed changes

merrymercy added 2 commits August 31, 2026 02:09

rust-server-cleanup(utils,non_mechanical_provable): name startup help…

7a10224

…ers precisely

Merge updated rust-server-cleanup-2-config

6935e27

rainj-me approved these changes Aug 31, 2026

View reviewed changes

Base automatically changed from rust-server-cleanup-2-config to main August 31, 2026 19:30

merrymercy requested review from Ying1123, hnyls2002 and xiezhq-hermann as code owners August 31, 2026 19:30

Merge main into rust-server-cleanup-3-parity

b0e8e8b

merrymercy merged commit 2138494 into main Aug 31, 2026
8 of 16 checks passed

merrymercy deleted the rust-server-cleanup-3-parity branch August 31, 2026 19:31

StevenChenSE pushed a commit to StevenChenSE/sglang that referenced this pull request Sep 6, 2026

[Rust] Keep sampling and scheduler wire schemas in sync (sgl-project#…

92efc1a

…37222)

bingxche mentioned this pull request Sep 11, 2026

[CI Monitor] Daily Report - 2026-09-11 bingxche/sglang-ci-bot#192

Open

merrymercy mentioned this pull request Oct 6, 2026

Add Rust code owners and grant shodoco CI permissions #42826

Merged

3 tasks done

Conversation

merrymercy commented Aug 31, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Test plan

Stack

CI States

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merrymercy left a comment

Choose a reason for hiding this comment

Uh oh!

merrymercy left a comment

Choose a reason for hiding this comment

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

merrymercy commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

merrymercy commented Aug 31, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading

github-actions Bot commented Aug 31, 2026 •

edited

Loading