Skip to content

fix: improve the maintainers_guide local development instruction - #2422

Merged
WilliamBergamin merged 5 commits into
mainfrom
improve-maintainers-guide
Feb 11, 2025
Merged

WilliamBergamin merged 5 commits into
mainfrom
improve-maintainers-guide

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Summary

This PR aims to address these comments from #2372

Requirements (place an x in each [ ])

@WilliamBergamin WilliamBergamin added enhancement M-T: A feature request for new functionality docs M-T: Documentation work only labels Feb 11, 2025
@WilliamBergamin WilliamBergamin self-assigned this Feb 11, 2025
@codecov

codecov Bot commented Feb 11, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 92.59%. Comparing base (5b5bd89) to head (77d4eed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2422   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few more notes to make this even more clear, but this is nice improvement πŸ“š ✨

Comment thread .github/maintainers_guide.md Resolved
Comment thread .github/maintainers_guide.md Resolved
Comment thread .github/maintainers_guide.md Resolved
Comment thread .github/maintainers_guide.md Resolved
Comment thread .github/maintainers_guide.md Resolved
WilliamBergamin and others added 4 commits February 11, 2025 13:44
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
@WilliamBergamin
WilliamBergamin merged commit 3f70613 into main Feb 11, 2025
@WilliamBergamin
WilliamBergamin deleted the improve-maintainers-guide branch February 11, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only enhancement M-T: A feature request for new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants