Skip to content

refactor: remove unused SemVerLessThan function - #704

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-unused-semverlessthan
Oct 14, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-unused-semverlessthan

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes the unused SemVerLessThan function found with the Go deadcode tool, so maintainers have less code to read and keep tested.

  • Removes SemVerLessThan from internal/update/semver.go
  • Removes its unit test from internal/update/semver_test.go

SemVerGreaterThan and ensureVPrefix stay, since the update checks still use them.

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep SemVerLessThan and confirm there's no output
  2. Run grep -rn "SemVerLessThan" --include='*.go' . and confirm there are no references left
  3. Run go test ./internal/update/... and confirm it passes

Requirements

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 78.17%. Comparing base (09c7e27) to head (b0a8e67).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   78.17%   78.17%   -0.01%     
==========================================
  Files         239      239              
  Lines       18164    18155       -9     
==========================================
- Hits        14200    14192       -8     
+ Misses       3964     3963       -1     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 14, 2026
@mwbrooks mwbrooks added this to the Next Release milestone Oct 14, 2026
@mwbrooks mwbrooks self-assigned this Oct 14, 2026
@mwbrooks
mwbrooks marked this pull request as ready for review October 14, 2026 18:13
@mwbrooks
mwbrooks requested a review from a team as a code owner October 14, 2026 18:13

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks πŸͺ“ LGTM - We love the axe!

@mwbrooks

Copy link
Copy Markdown
Member Author

Super fast, thanks a bunch @zimeg! πŸ™‡πŸ»

@mwbrooks
mwbrooks merged commit 49cd54a into main Oct 14, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-unused-semverlessthan branch October 14, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants