Repository navigation
refactor: remove unused SemVerLessThan function - #704
Merged
Merged
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 78.17% 78.17% -0.01%
==========================================
Files 239 239
Lines 18164 18155 -9
==========================================
- Hits 14200 14192 -8
+ Misses 3964 3963 -1 β View full report in Codecov by Harness. π New features to boost your workflow:
|
mwbrooks
marked this pull request as ready for review
October 14, 2026 18:13
Member
Author
|
Super fast, thanks a bunch @zimeg! ππ» |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal cleanup with no user-facing changes.
Summary
This pull request removes the unused
SemVerLessThanfunction found with the Godeadcodetool, so maintainers have less code to read and keep tested.SemVerLessThanfrominternal/update/semver.gointernal/update/semver_test.goSemVerGreaterThanandensureVPrefixstay, since the update checks still use them.Testing
go run golang.org/x/tools/cmd/deadcode@latest ./... | grep SemVerLessThanand confirm there's no outputgrep -rn "SemVerLessThan" --include='*.go' .and confirm there are no references leftgo test ./internal/update/...and confirm it passesRequirements