Skip to content

chore: remove the docs sync app secrets from the maintainers guide - #756

Merged
zimeg merged 1 commit into
mainfrom
docs-remove-sync-secrets
Nov 6, 2026
Merged

zimeg merged 1 commit into
mainfrom
docs-remove-sync-secrets

Conversation

@zimeg

@zimeg zimeg commented Nov 6, 2026

Copy link
Copy Markdown
Member

Changelog

N/A. This only changes the maintainers guide.

Summary

This pull request removes the "Synchronizing changes upstream" section from the maintainers guide, along with the GH_APP_ID_DOCS and GH_APP_PRIVATE_KEY_DOCS secrets it lists.

  • build: clone repository "docs" and configuration when syncing project docsย #145 removed the sync-docs-from-cli-repo.yml workflow that used these secrets, so no workflow references them now.
  • This also drops the section's outline entry and its [sync] and [github-app-docs] link references. The [sync] link pointed at the deleted workflow file.
  • Once this merges, the two unused repository secrets can be deleted.

Preview

N/A

Testing

  • Search the repo for GH_APP_ID_DOCS and GH_APP_PRIVATE_KEY_DOCS and confirm nothing references them.
  • Open the guide's "Tasks" outline and confirm "Generating documentation" is followed by "Versioning", with no broken anchors.

Notes

The repository secrets themselves are removed separately in settings after merge.

Requirements

๐Ÿค– Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@zimeg zimeg added this to the Next Release milestone Nov 6, 2026
@zimeg zimeg added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Nov 6, 2026
@zimeg zimeg self-assigned this Nov 6, 2026
@zimeg zimeg removed the docs M-T: Documentation work only label Nov 6, 2026
@zimeg zimeg changed the title docs: remove the docs sync app secrets from the maintainers guide chore: remove the docs sync app secrets from the maintainers guide Nov 6, 2026
@zimeg
zimeg marked this pull request as ready for review November 6, 2026 01:09
@zimeg
zimeg requested a review from a team as a code owner November 6, 2026 01:09
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 78.43%. Comparing base (19c588c) to head (636c9ae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   78.41%   78.43%   +0.01%     
==========================================
  Files         240      240              
  Lines       18179    18179              
==========================================
+ Hits        14255    14258       +3     
+ Misses       3924     3921       -3     

โ˜” View full report in Codecov by Harness.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukegalbraithrussell lukegalbraithrussell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this takes me back. thank you!

@zimeg

zimeg commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

๐Ÿงน Thanks for the kind review @lukegalbraithrussell! One less stale section to trip over.

@zimeg
zimeg merged commit 0e00202 into main Nov 6, 2026
14 checks passed
@zimeg
zimeg deleted the docs-remove-sync-secrets branch November 6, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants