Repository navigation
test: add unit tests for bundleArchive in internal/pkg/platform - #769
Merged
Merged
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 78.64% 78.90% +0.26%
==========================================
Files 240 240
Lines 18205 18205
==========================================
+ Hits 14317 14365 +48
+ Misses 3888 3840 -48 β View full report in Codecov by Harness. π New features to boost your workflow:
|
Member
Author
|
Thanks @zimeg for the quick review! π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - adds tests only, with no user-facing changes.
Summary
This pull request adds unit tests for
bundleArchiveininternal/pkg/platform/deploy.go, which had no test coverage. It is one in a series of small coverage PRs for maintainers.Test_bundleArchivetointernal/pkg/platform/deploy_test.gowith cases for nested file paths and contents in the zip, an empty directory, and a missing directoryinternal/pkg/platformcoverage from 45.2% to 51.6%Testing
go test ./internal/pkg/platform/... -run Test_bundleArchive -vand confirm the cases passRequirements