Repository navigation
Closed
Labels
area:containerIssue with the generic container generatorIssue with the generic container generatorarea:genericIssue with the generic generatorIssue with the generic generatorarea:goIssue related to the Go ecosystemIssue related to the Go ecosystemtype:bugSomething isn't workingSomething isn't working
Milestone
Description
Describe the bug
Creating signed provenance fails with
##[debug]/usr/bin/bash --noprofile --norc -e -o pipefail /home/runner/work/_temp/12f3ed8f-b71f-4b24-816e-9adc5a6a9d03.sh
Retrieving signed certificate...
Note that there may be personally identifiable information associated with this signed artifact.
This may include the email address associated with the account with which you authenticate.
This information will be used for signing this artifact and will be stored in public transparency logs and cannot be removed later.
validating log entry: unable to fetch Rekor public keys from TUF repository, and not trusting the Rekor API for fetching public keys: updating local metadata and targets: error updating to TUF remote mirror: tuf: invalid key
remote status:{
"mirror": "sigstore-tuf-root",
"metadata": {
"root.json": {
"version": 5,
"len": 6388,
"expiration": "18 Apr 23 18:13 UTC",
"error": ""
},
"snapshot.json": {
"version": 53,
"len": 1973,
"expiration": "10 Nov 22 21:10 UTC",
"error": ""
},
"targets.json": {
"version": 5,
"len": 4188,
"expiration": "18 Apr 23 18:13 UTC",
"error": ""
},
"timestamp.json": {
"version": 53,
"len": 719,
"expiration": "03 Nov 22 21:10 UTC",
"error": ""
}
}
}
Error: Process completed with exit code 1.
##[debug]Finishing: Create and sign provenance
To Reproduce
This happens in a private repository, based on the this job:
provenance:
needs: build
# The generator should be referenced with a semantic version.
# The build will fail if we reference it using the commit sha.
uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v1.2.0
with:
base64-subjects: ${{ needs.build.outputs.artifacts-sha256 }}
permissions:
actions: read # To read the workflow path.
id-token: write # To sign the provenance.
contents: write # To add assets to a release.Expected behavior
Finish successfully.
Screenshots
Additional context
Iβm going to be honest: Iβm trying to convince people in my org to integrate SLSA into the CI and build processes, but itβs getting harder when the actions break with different issues every other week.
I just updated to v1.2.1 and hope thatβll work.
Metadata
Metadata
Assignees
Labels
area:containerIssue with the generic container generatorIssue with the generic container generatorarea:genericIssue with the generic generatorIssue with the generic generatorarea:goIssue related to the Go ecosystemIssue related to the Go ecosystemtype:bugSomething isn't workingSomething isn't working
Activity
jenstroeger commentedon Oct 26, 2022
And v1.2.1 fails with
which isnβt documented. So based on the src I guess I need to use
and that means that the name of the repository βleaksββ¦ whereβs that transparency log accessible?
ianlewis commentedon Oct 27, 2022
Yeah, forgetting to add that to the docs was an oversight on our part. The reason for it is that the repository name is uploaded as part of the transparency log entry on the public Rekor instance (rekor.sigstore.dev) and can be found via the Rekor API. This might be considered a "leak" if the repo is private but you can explicitly opt-in if you are ok with that. I will create a PR to document it today.
For those who don't want repo names to leak on the public Rekor instance, we have an issue to track support for using a private Rekor instance (#34) and we may prioritize adding that now that Rekor 1.0 was released and the API and public instance will hopefully be a bit more stable. It's been a big concern for us so we've been working with that team to figure out ways to catch issues earlier so they don't end up affecting users.
jenstroeger commentedon Oct 27, 2022
@ianlewis thanks for the answer, adding
private-repositoryworked.However, I want to emphasize that this bug still applies to v1.2.0 and a fix update & bump to v1.2.1 should not leave behind a broken service!
ianlewis commentedon Oct 27, 2022
Thanks for the feedback. We'll try to adhere to semantic versioning better going forward.
[-][bug] Creating and signing provenance fails because retrieving signed certificate fails.[/-][+][docs] Document private-repository input.[/+]jenstroeger commentedon Oct 27, 2022
@ianlewis what are you saying? That you folks intentionally broke v1.2.0? Youβve changed this issue to a documentation changeβ¦ whatβs with the invalid key that breaks the generator?
ianlewis commentedon Oct 27, 2022
I'm saying that the
private-repositoryinput is working as intended. It's an opt in flag for users to indicate that it's ok for private repository names to be uploaded to the public transparency log.However, since it wasn't a simple bugfix upgrade from v1.2.0 to v1.2.1 without adding that input we probably should have set the version at 1.3.0 to indicate that.
private-repositorydoesn't have anything to do with v1.2.0 though. It was added in v1.2.1.jenstroeger commentedon Oct 27, 2022
Regarding v1.2.0: is that version dead and deprecated, or is it supposed to be functioning (because it isnβt, hence this bug report).
ianlewis commentedon Oct 27, 2022
Ok, I see. Sorry for the confusion. Yes. Version v1.2.0 is broken for reasons that are outside the scope of this project and is not likely to get fixed.
I'll try to add some more doc to communicate that better.
jenstroeger commentedon Oct 27, 2022
So⦠the supply chain tools are broken by their own supply chain? And by being broken as v1.2.0 is it itself becomes a faulty link in the software supply chain.
Ironic.
45 remaining items
ianlewis commentedon Nov 15, 2022
v1.2.2 was released and includes fixes for this issue. Users should upgrade to this release to solve this issue. Users should no longer need to set the
compile-builderinput workaround after upgrade.v1.2.1 is deprecated and should not be used.
Fix: Use attestation-name output
Fix: Use attestation-name output
Fix: Use attestation-name output
Fix: Use attestation-name output (#980)
sgammon commentedon Mar 20, 2024
This is happening again, starting today... @ianlewis
Job log
ianlewis commentedon Mar 21, 2024
Yeah, Sigstore updates their TUF root keys for the public instance and expects everyone to upgrade to their latest version of the sigstore client. It makes it a bit difficult for downstream users like us to keep up or even know when breakages are coming (even when we are a sigstore adjacent project...)
Workaround for slsa-framework/slsa-github-generator#1163
Temporary fix for SLSA generators (google#7636)
Temporary fix for SLSA generators (google#7636)
Temporary fix for SLSA generators (#7636)
Temporary fix for SLSA generators (#7636)
fix(ci): unblock SLSA Release Attestation β 6 releases failed identicβ¦
docs(security): document SLSA-generator pin as known Scorecard false β¦