Repository navigation
fix(web3.js): keep sig-status fallback errs from escaping as unhandled rej - #3936
Merged
Merged
Conversation
…unhandled rejections The detached status read that runs after signature subscription setup settles had no rejection path, so a transient transport or JSON-RPC failure surfaced as an unhandled promise rejection, which terminates modern Node processes. The read is only an early-settlement optimization, so its failure is now swallowed and confirmation is left to the signature subscription and the caller's expiry strategy, which already double-check the signature status before declaring expiry. Fixes DEV-1132
Contributor
|
dev-jodee
approved these changes
Sep 18, 2026
dev-jodee
left a comment
Collaborator
There was a problem hiding this comment.
Error handling: catch transient sig-status fallback errors to prevent unhandled rejections. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
confirmTransactionmakes a detachedgetSignatureStatuscall after subscription setup as an early-settlement optimization. It had no rejection handler, so a transient transport or JSON-RPC failure surfaced as an unhandled promise rejection, which terminates modern Node processes by default.The call is only an optimization; the signature subscription and the expiry strategy's final status check already settle the confirmation. Its failure is now caught and ignored.
Test: first
getSignatureStatusesrejects, subscription never responds, block height passeslastValidBlockHeight. Asserts nounhandledRejectionfires and the transaction still confirms via the expiry path.Fixes DEV-1132