Skip to content

fix: typedoc on main - #3956

Merged
amilz merged 3 commits into
mainfrom
fix/DEV-1151-typedoc-warnings
Sep 28, 2026
Merged

amilz merged 3 commits into
mainfrom
fix/DEV-1151-typedoc-warnings

Conversation

@amilz

@amilz amilz commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator
  • Fixes the TypeDoc warnings on main so compile:docs passes & enforces it via a new CI step and just docs.
  • Ports the GitHub Pages publish and preview workflows from maintenance/v1.x to the monorepo: every merge to main publishes v3 docs to the site root and v3.x/, preserving the existing v1.x/ folder on gh-pages.
  • Updated npm icon to show RC for correct version

Register intentionally unexported helper aliases in typedoc.json, map
inherited Kit symbol links, and override two inherited Kit doc comments
whose {@link} targets cannot resolve from this package. Add a Compile
Docs step to the web3.js CI job so --treatWarningsAsErrors stays green.

Refs: DEV-1151
Port the publish and preview GitHub Pages workflows from maintenance/v1.x
to the monorepo. Docs are built from packages/web3.js and deployed to the
site root and a v3.x/ subdirectory; versioned directories already on the
gh-pages branch (v1.x/) are carried over so the two branches no longer
overwrite each other's output.

Refs: DEV-1151
@amilz amilz self-assigned this Sep 25, 2026
@linear

linear Bot commented Sep 25, 2026

Copy link
Copy Markdown

DEV-1151

@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High risk] Adds documentation generation to CI and deploys to GitHub Pages.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR makes TypeDoc compilation part of CI and just docs, updates documentation links and the npm badge, and adds a workflow to publish v3 docs while preserving versioned docs. The PR-preview workflow added earlier in this branch was removed before this review.

Reviews (2) · Last reviewed commit: "ci: address gh-pages review feedback"

Comment thread .github/workflows/preview-gh-pages.yml Resolved
Comment thread packages/web3.js/typedoc.json Resolved
Drop the PR preview workflow: the token it needs was never provisioned
in this repository and previews have been failing on every PR. Set
read-only default token permissions on the publish workflow. Point the
external TypeDoc symbol links at the published Kit API reference instead
of empty anchors.

Refs: DEV-1151

@dev-jodee dev-jodee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typedoc/gh-pages CI setup. All checks passing.

@amilz
amilz merged commit 2c090ed into main Sep 28, 2026
5 checks passed
@amilz
amilz deleted the fix/DEV-1151-typedoc-warnings branch September 28, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants