Skip to content

chore(deps): bump @solana/kit-plugin-wallet to 0.23 - #4019

Merged
amilz merged 1 commit into
mainfrom
chore/bump-kit-plugin-wallet-0.23
Nov 2, 2026
Merged

amilz merged 1 commit into
mainfrom
chore/bump-kit-plugin-wallet-0.23

Conversation

@amilz

@amilz amilz commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator
  • Bump @solana/kit-plugin-wallet to ^0.23.0 (adds signOffchainMessage, supportsSignInWithOffchainMessage, and offchain SIWS output verification from Add SIWS v1.1.0 anza-xyz/kit-plugins#513). Peers: @solana/kit ^8.6.0, react/react-dom ^19.3.1, matching the plugin.
  • signOffchainMessage and the SIWS offchain version check now delegate to the plugin; the adapter's public API is unchanged.
  • verifySignIn now requires the canonical offchain message encoding (Kit's UTF-8 decoder drops \0, so padded bytes previously verified) and that account.publicKey encodes account.address.
    • signIn with useOffchainMessage on a wallet older than solana:signIn 1.1.0 now rejects with WalletSignInError (cause: Kit's SOLANA_ERROR__WALLET__FEATURE_VERSION_UNSUPPORTED) instead of WalletNotReadyError, still before the wallet is called.
  • Closes DEV-1296
  • AI tooling was used. Tool and extent: Claude drafted the PR & I reviewed/tested it.

Behavior changes for callers:

  • signOffchainMessage rejects with WalletSignOffchainMessageError unless the wallet signed exactly the requested message with the connected account; requiredSigners must include the connected key and be 32 bytes each.
  • Offchain signIn output is verified by the plugin (rejects with WalletSignInError); solana:signIn 1.1.0 or any later 1.x counts as supporting useOffchainMessage.

Note: overlaps #3994, which moves e2e/test-wallet.ts to packages/agent-wallet/src/wallet.ts; that copy still signs raw text for solana:signOffchainMessage and needs the same encoding fix on rebase.

@amilz amilz self-assigned this Nov 2, 2026
@linear

linear Bot commented Nov 2, 2026

Copy link
Copy Markdown

DEV-1296

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issue was established.

Summary

Updates @solana/kit-plugin-wallet to ^0.23.0 and aligns the Kit and React peer ranges.

  • Off-chain message signing returns only the connected account’s verified result.
  • Off-chain sign-in accepts later 1.x wallets and checks the signed output.
  • Wallet adapter installs use versions that match the newer Kit wallet plugin.

No actionable new issues were established. Dependencies were not installed, so tests and the plugin’s implementation were not verified directly.

Reviews (2) · Last reviewed commit: "chore(deps): bump kit-plugin-wallet to 0..." · Reviewed by Greptile

Delegate offchain message signing and SIWS v1.1.0 support checks to the plugin, and require canonical bytes and a matching public key in verifySignIn.
@amilz
amilz force-pushed the chore/bump-kit-plugin-wallet-0.23 branch from 5bb2131 to dcff17f Compare November 2, 2026 18:32
@amilz
amilz merged commit ae3655f into main Nov 2, 2026
11 checks passed
@amilz
amilz deleted the chore/bump-kit-plugin-wallet-0.23 branch November 2, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants