Repository navigation
chore(deps): bump @solana/kit-plugin-wallet to 0.23 - #4019
Merged
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no blocking issue was established. SummaryUpdates
No actionable new issues were established. Dependencies were not installed, so tests and the plugin’s implementation were not verified directly. Reviews (2) · Last reviewed commit: "chore(deps): bump kit-plugin-wallet to 0..." · Reviewed by Greptile |
Delegate offchain message signing and SIWS v1.1.0 support checks to the plugin, and require canonical bytes and a matching public key in verifySignIn.
amilz
force-pushed
the
chore/bump-kit-plugin-wallet-0.23
branch
from
November 2, 2026 18:32
5bb2131 to
dcff17f
Compare
dev-jodee
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@solana/kit-plugin-walletto^0.23.0(addssignOffchainMessage,supportsSignInWithOffchainMessage, and offchain SIWS output verification from Add SIWS v1.1.0 anza-xyz/kit-plugins#513). Peers:@solana/kit^8.6.0,react/react-dom^19.3.1, matching the plugin.signOffchainMessageand the SIWS offchain version check now delegate to the plugin; the adapter's public API is unchanged.verifySignInnow requires the canonical offchain message encoding (Kit's UTF-8 decoder drops\0, so padded bytes previously verified) and thataccount.publicKeyencodesaccount.address.signInwithuseOffchainMessageon a wallet older thansolana:signIn1.1.0now rejects withWalletSignInError(cause: Kit'sSOLANA_ERROR__WALLET__FEATURE_VERSION_UNSUPPORTED) instead ofWalletNotReadyError, still before the wallet is called.Behavior changes for callers:
signOffchainMessagerejects withWalletSignOffchainMessageErrorunless the wallet signed exactly the requested message with the connected account;requiredSignersmust include the connected key and be 32 bytes each.signInoutput is verified by the plugin (rejects withWalletSignInError);solana:signIn1.1.0or any later1.xcounts as supportinguseOffchainMessage.Note: overlaps #3994, which moves
e2e/test-wallet.tstopackages/agent-wallet/src/wallet.ts; that copy still signs raw text forsolana:signOffchainMessageand needs the same encoding fix on rebase.