Skip to content
This repository was archived by the owner on Aug 26, 2026. It is now read-only.
This repository was archived by the owner on Aug 26, 2026. It is now read-only.

Use substring instead of replaceFirst in OAuth2AuthorizationConsent #1222

Closed
Closed
Use substring instead of replaceFirst in OAuth2AuthorizationConsent#1222
Assignees
heartape
Labels
type: enhancementA general enhancement
Milestone
1.1.1

Description

@heartape
heartape
opened on May 22, 2023

Expected Behavior
Will bring 40 times the performance improvement

Current Behavior

Context
Recently, I have been studying the source code of this framework, and during this period, I have discovered some code that may have optimization value. such as:
https://github.com/spring-projects/spring-authorization-server/blob/878a75d6ed4a2f848316245d91fc55c774070d81/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/OAuth2AuthorizationConsent.java#L96
I conducted a simple test and achieved a 40 times performance improvement.

Activity

  1. heartape
    added
    type: enhancementA general enhancement
    on May 22, 2023
  2. jgrandja
    added
    status: waiting-for-feedbackWe need additional information before we can continue
    and removed
    type: enhancementA general enhancement
    on May 26, 2023
  3. jgrandja
    changed the title [-]Using substring instead of replaceFirst[/-] [+]Use substring instead of replaceFirst in OAuth2AuthorizationConsent[/+] on May 29, 2023
  4. jgrandja
    assigned
    heartape
    on May 29, 2023
  5. jgrandja
    added
    type: enhancementA general enhancement
    and removed
    status: waiting-for-feedbackWe need additional information before we can continue
    on May 29, 2023
  6. jgrandja
    added this to the 1.1.1 milestone on May 29, 2023
  7. jgrandja
    closed this as completedin a731811on May 29, 2023
  8. tjholmes66
    added a commit that references this issue on Oct 2, 2023

    Get latest from source (#2)

    219ef93
  9. myy520
    added a commit that references this issue on Feb 19, 2024

    Use substring instead of replaceFirst in OAuth2AuthorizationConsent

    a731811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: enhancementA general enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions