Skip to content
This repository was archived by the owner on Aug 26, 2026. It is now read-only.
This repository was archived by the owner on Aug 26, 2026. It is now read-only.

code_challenge_methods_supported field not in openid-configuration endpoint #1302

Closed

Description

@Tuxzx

Expected Behavior
The code_challenge_methods_supported field should be included in the .well-known/openid-configuration endpoint.

Current Behavior
Currently, the code_challenge_methods_supported field is only available in the .well-known/oauth-authorization-server endpoint, However, we typically only use auto-discovery when using OIDC clients.

Context
In popular identity providers like Keycloak and Google (e.g., https://accounts.google.com/.well-known/openid-configuration), the code_challenge_methods_supported field is included in the openid endpoint. Some clients, such as the OAuth4WebAPI library (https://github.com/panva/oauth4webapi), also support this field.

Activity

  1. jgrandja commented on Jul 31, 2023

    @jgrandja
    Contributor

    Thanks for the report @drunkcattt. Would you be interested in submitting a PR for this enhancement?

    In the meantime, you can customize the OpenID Connect 1.0 Provider Configuration Endpoint and add the code_challenge_methods_supported metadata. See providerConfigurationCustomizer() in the reference documentation.

  2. Tuxzx commented on Aug 7, 2023

    @Tuxzx
    ContributorAuthor


    https://github.com/spring-projects/spring-authorization-server/blob/0a87e78bd1ac9e37f7c5d2c5f97de81c4d995085/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/CodeVerifierAuthenticator.java#L140-L158

    #1329

    According to the processing logic of the CodeVerifierAuthenticator, I have directly added .codeChallengeMethod("S256") to the OidcProviderConfigurationEndpointFilter, similar to the OAuth2AuthorizationServerMetadataEndpointFilter.

  3. added this to the 1.2.0-M1 milestone on Aug 16, 2023
  4. added a commit that references this issue on Oct 2, 2023
    219ef93
  5. added a commit that references this issue on Feb 1, 2024
    5fe955a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions