Skip to content

Gh 3718 add zoned loadbalancer instrumentation - #3720

Merged
OlgaMaciaszek merged 4 commits into
masterfrom
gh-3718-add-zoned-loadbalancer-instrumentation
Dec 19, 2019
Merged

OlgaMaciaszek merged 4 commits into
masterfrom
gh-3718-add-zoned-loadbalancer-instrumentation

Conversation

@OlgaMaciaszek

@OlgaMaciaszek OlgaMaciaszek commented Dec 18, 2019 •

Copy link
Copy Markdown
Collaborator

Fixes gh-3781

@codecov

codecov Bot commented Dec 18, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #3720 into master will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3720      +/-   ##
============================================
+ Coverage     65.75%   65.82%   +0.06%     
- Complexity     1580     1592      +12     
============================================
  Files           200      203       +3     
  Lines          7420     7455      +35     
  Branches        871      877       +6     
============================================
+ Hits           4879     4907      +28     
- Misses         2225     2226       +1     
- Partials        316      322       +6
Impacted Files Coverage Δ Complexity Δ
...eka/loadbalancer/EurekaLoadBalancerProperties.java 100% <100%> (ø) 3 <3> (?)
...dbalancer/LoadBalancerEurekaAutoConfiguration.java 100% <100%> (ø) 3 <3> (?)
...alancer/EurekaLoadBalancerClientConfiguration.java 74.07% <74.07%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51a15c...4d82244. Read the comment docs.

@spencergibb spencergibb removed this from the 2.2.1.SR1 milestone Dec 18, 2019
@OlgaMaciaszek

Copy link
Copy Markdown
Collaborator Author

IMPORTANT: Only merge after this one has been merged.

@OlgaMaciaszek

Copy link
Copy Markdown
Collaborator Author

Tests will stop failing after merging spring-cloud/spring-cloud-commons#662

@OlgaMaciaszek
OlgaMaciaszek merged commit 23659f8 into master Dec 19, 2019
sabareeshkkanan added a commit to sabareeshkkanan/spring-cloud-netflix that referenced this pull request Dec 20, 2019
* Added symbolic link of index.adoc

* Added symbolic link of index.adoc

* set replication client filters in RefreshablePeerEurekaNodes (spring-cloud#3610)

fixes spring-cloudgh-3554

* Update SNAPSHOT to 2.2.0.M2

* Going back to snapshots

* Adding spring cloud circuitbreaker hystrix implementation

* Separated circuitbreaker auto config to its own file

* Initialize remoteRegionAppWhitelist with default value (spring-cloud#3634)

* Moves non-netflix dependencies out of bom into root pom.

fixes spring-cloudgh-3639

* Removes dependency management for okhttp3

* Moves okhttp3 dep mgmt back to bom

* Re-create connection manager on "zuul.host.*" property change (spring-cloud#3407)

* Re-create connection manager on "zuul.host.*" property change 

Fixes spring-cloud#3406

* Wrap connectionManager.shutdown() in try/catch block. Polishing

* Removes okhttp3 again after added back in older branch.

* Updating readme with note about building spring-cloud-netflix-hystrix-contract.  Fixes spring-cloud#3497

* Fromatting

* Upgrades eureka to 1.9.13 and excludes compactmap.

fixes spring-cloudgh-3636

* Update SNAPSHOT to 2.1.3.RELEASE

* Going back to snapshots

* Bumping versions to 2.1.4.BUILD-SNAPSHOT after release

* Add Spring Cloud LoadBalancer starter to Eureka starters. Fixes spring-cloudgh-3646. (spring-cloud#3647)

* Update docs. (spring-cloud#3650)

* ConditionalOnMissingBean on formBodyWrapperFilter, debugFilter… (spring-cloud#3609)

* Bumping versions

* Remove spring.provides.

* removes useless comments

* Fix RestTemplateEurekaHttpClient status update endpoint.  Fixes spring-cloud#3571 (spring-cloud#3657)

* polish

* Updates health check handler to use new StatusAggregator

* Gh 3409 turbine stream test (spring-cloud#3665)

* Add stream-test-support.

* Fix condition.

* Remove outdated workaround.

* Bumping versions

* Optimize code of eureka (spring-cloud#3660)

* Optimize code of eureka

* Merge newest code

* fix checkstyle bug

* Gh 3464 upgrade scc new (spring-cloud#3667)

* Upgrade Spring Cloud Contract version to 2.1.3.RELEASE.

* Gh 3409 turbine stream test (spring-cloud#3665)

* Add stream-test-support.

* Fix condition.

* Remove outdated workaround.

(cherry picked from commit 24f5e0b)

* Updates to use "components" rather than "details"

See spring-projects/spring-boot#17929

* Applying spring-cloud#3407 to the 2.1.x branch

* Added support for reactive service discovery

* Update SNAPSHOT to 2.2.0.M3

* Going back to snapshots

* Update SNAPSHOT to 2.2.0.RC1

* Going back to snapshots

* removing resource class from circle config

* Add property to disable spring cloud circuit breaker for hystrix

* Fix command key configuration.  Use id as command key and class as group key.

* Adding configuration metadata for spring cloud circuitbreaker

* Bumping versions

* Fix some dependencies that show up in the wrong scope

Apparently you can build on the command line but Eclipse is fussy
now and wouldn't compile these projects without explicit
dependencies.

* Also add build helper config for contract tests

* Added maven flatten plugin

* Bumping versions

* Update SNAPSHOT to 2.2.0.RC2

* Going back to snapshots

* Update configuration to use proxyBeanMethods=false.  Fixes spring-cloud#3677

* Create security.md

* Update issue templates

* Bumping versions

* Bumping versions

* Update SNAPSHOT to 2.2.0.RELEASE

* Going back to snapshots

* Bumping versions to 2.2.1.BUILD-SNAPSHOT after release

* Bumping versions

* Fix typo: clas -> class (spring-cloud#3710)

* removes .flattened-pom.xml

* ignores .flattened-pom.xml

* Gh 3718 add zoned loadbalancer instrumentation (spring-cloud#3720)

* Add instrumentation for zoned LoadBalancer.

* Add documentation.

* Fix after review.

* Fix after review.

* Update SNAPSHOT to 2.2.1.RELEASE

* Going back to snapshots

* Bumping versions to 2.2.2.BUILD-SNAPSHOT after release

Co-authored-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
Co-authored-by: Yuxin Bai <LittleBaiBai@users.noreply.github.com>
Co-authored-by: Spencer Gibb <spencer@gibb.tech>
Co-authored-by: Spring Buildmaster <buildmaster@springframework.org>
Co-authored-by: Ryan Baxter <rbaxter@pivotal.io>
Co-authored-by: emilnkrastev <emilnkrastev@gmail.com>
Co-authored-by: Denys Ivano <denys.ivano@gmail.com>
Co-authored-by: Olga Maciaszek-Sharma <olga.maciaszek@gmail.com>
Co-authored-by: Rafał Żukowski <rzukow@gmail.com>
Co-authored-by: OLPMO <OLPMO@users.noreply.github.com>
Co-authored-by: Tim Ysewyn <Tim.Ysewyn@me.com>
Co-authored-by: Dave Syer <david_syer@hotmail.com>
Co-authored-by: Deepika Mohan <deepikadevidm@gmail.com>
@OlgaMaciaszek OlgaMaciaszek added this to the 3.0.0.M1 milestone Apr 17, 2020
@OlgaMaciaszek
OlgaMaciaszek deleted the gh-3718-add-zoned-loadbalancer-instrumentation branch December 2, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants