Repository navigation
Revert changes in config server bootstrapper and use new PropertyResolver class - #328
Conversation
|
@pantherdd I think this is ultimately a better solution to #324. It takes your idea of registering the Note it depends on changes in spring-cloud/spring-cloud-config#2375 If you agree we can merge these changes and close #327 |
|
@ryanjbaxter Great news, thanks for giving this idea a try and making it work. I'm going to review this PR today. FTR, the breaking changes (that this PR is reverting) were introduced to the |
|
With most of the earlier changes reverted, do we still need these to exist, or can we remove them too?
After this change, they seem to be dead code basically. Unless I'm missing some other use for them. |
ad32f45 to
51d7e14
Compare
|
Thanks @pantherdd! I have made your suggested changes. Regarding the "dead code" in |
Reverts https://github.com/spring-cloud/spring-cloud-zookeeper/pull/325/files and https://github.com/spring-cloud/spring-cloud-zookeeper/pull/317/files and also address #324
Depends on spring-cloud/spring-cloud-config#2375