You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add configuration property for supported media types with reactive Mustache viewsΒ #28858
MustacheProperties has a content-type but this isn't a list and isn't used in the reactive case.
Spring Boot has support for Thymeleaf (reactive only?) configuration to set the support media types of the views as a list, so it seems like they could be more consistent.
changed the title [-]Add configuration property for supported media types with Mustache views[/-][+]Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views[/+]on Nov 30, 2021
Yes, spring.thymeleaf.reactive.media-types is specific to reactive apps.
To be consistent with Thymeleaf in this area, it looks like we're missing a spring.mustache.servlet.content-type property and a spring.mustache.reactive.media-types property.
There's already a spring.mustache.content-type property but it is Servlet-specific. To make that clear it should move to spring.mustache.servlet.content-type. This will mean that MustacheProperties can no longer extend AbstractTemplateViewResolverProperties. There are other spring.mustache.* properties that also appear to be specific to Servlet apps:
spring.mustache.allow-request-override
spring.mustache.allow-session-override
spring.mustache.cache
spring.mustache.expose-request-attributes
spring.mustache.expose-session-attributes
spring.mustache.expose-spring-macro-helpers
We should double-check each of these as part of separating out the reactive- and servlet-specific properties.
changed the title [-]Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views[/-][+]Add a configuration property for supported media types with reactive Mustache views[/+]on Mar 17, 2022
changed the title [-]Add a configuration property for supported media types with reactive Mustache views[/-][+]Add configuration property for supported media types with reactive Mustache views[/+]on Mar 17, 2022
Activity
[-]Add configuration property for supported media types with Mustache views[/-][+]Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views[/+]wilkinsona commentedon Nov 30, 2021
Yes,
spring.thymeleaf.reactive.media-typesis specific to reactive apps.To be consistent with Thymeleaf in this area, it looks like we're missing a
spring.mustache.servlet.content-typeproperty and aspring.mustache.reactive.media-typesproperty.wilkinsona commentedon Dec 2, 2021
There's already a
spring.mustache.content-typeproperty but it is Servlet-specific. To make that clear it should move tospring.mustache.servlet.content-type. This will mean thatMustachePropertiescan no longer extendAbstractTemplateViewResolverProperties. There are otherspring.mustache.*properties that also appear to be specific to Servlet apps:spring.mustache.allow-request-overridespring.mustache.allow-session-overridespring.mustache.cachespring.mustache.expose-request-attributesspring.mustache.expose-session-attributesspring.mustache.expose-spring-macro-helpersWe should double-check each of these as part of separating out the reactive- and servlet-specific properties.
[-]Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views[/-][+]Add a configuration property for supported media types with reactive Mustache views[/+][-]Add a configuration property for supported media types with reactive Mustache views[/-][+]Add configuration property for supported media types with reactive Mustache views[/+]wilkinsona commentedon Mar 17, 2022
Rearranging the properties to make it clear which are Servlet-specific has been done in #30273.
Add property for media types of reactive Mustache views