Skip to content

Add configuration property for supported media types with reactive Mustache viewsΒ #28858

Closed

Description

@dsyer

MustacheProperties has a content-type but this isn't a list and isn't used in the reactive case.

Spring Boot has support for Thymeleaf (reactive only?) configuration to set the support media types of the views as a list, so it seems like they could be more consistent.

Activity

  1. changed the title [-]Add configuration property for supported media types with Mustache views[/-] [+]Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views[/+] on Nov 30, 2021
  2. wilkinsona commented on Nov 30, 2021

    @wilkinsona
    Member

    Yes, spring.thymeleaf.reactive.media-types is specific to reactive apps.

    To be consistent with Thymeleaf in this area, it looks like we're missing a spring.mustache.servlet.content-type property and a spring.mustache.reactive.media-types property.

  3. added and removed
    status: waiting-for-triageAn issue that has not yet been triaged. Contributions will not be accepted.
    on Nov 30, 2021
  4. added this to the 2.7.x milestone on Nov 30, 2021
  5. wilkinsona commented on Dec 2, 2021

    @wilkinsona
    Member

    There's already a spring.mustache.content-type property but it is Servlet-specific. To make that clear it should move to spring.mustache.servlet.content-type. This will mean that MustacheProperties can no longer extend AbstractTemplateViewResolverProperties. There are other spring.mustache.* properties that also appear to be specific to Servlet apps:

    • spring.mustache.allow-request-override
    • spring.mustache.allow-session-override
    • spring.mustache.cache
    • spring.mustache.expose-request-attributes
    • spring.mustache.expose-session-attributes
    • spring.mustache.expose-spring-macro-helpers

    We should double-check each of these as part of separating out the reactive- and servlet-specific properties.

  6. self-assigned this
    on Mar 16, 2022
  7. changed the title [-]Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views[/-] [+]Add a configuration property for supported media types with reactive Mustache views[/+] on Mar 17, 2022
  8. changed the title [-]Add a configuration property for supported media types with reactive Mustache views[/-] [+]Add configuration property for supported media types with reactive Mustache views[/+] on Mar 17, 2022
  9. modified the milestones: 2.7.x, 2.7.0-M3 on Mar 17, 2022
  10. wilkinsona commented on Mar 17, 2022

    @wilkinsona
    Member

    Rearranging the properties to make it clear which are Servlet-specific has been done in #30273.

  11. added a commit that references this issue on Aug 12, 2026
    b787ea4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions