Repository navigation
Fix count query transformation that renders statements invalid. - #4361
Closed
christophstrobl wants to merge 3 commits into
Closed
christophstrobl wants to merge 3 commits into
christophstrobl wants to merge 3 commits into
Conversation
Introduce CountSelectionSupport to unify code paths for transforming queries into their count query represenation. This commit fixes an issue where the created token stream missed to detect expressions correctly which resulted in broken rendering missing whitespaces between tokens. Count queries for constructor espressions now also extract the respective selections.
Invert the relationship between the inherited grammar interface and actual count-rendering methods so that CountSelection remains the main component for rendering the count selection while a CountQueryTransformer only implements the methods necessary for rendering.
mp911de
pushed a commit
that referenced
this pull request
Oct 15, 2026
Introduce CountSelectionSupport to unify code paths for transforming queries into their count query representation. This commit fixes an issue where the created token stream missed to detect expressions correctly which resulted in broken rendering missing whitespaces between tokens. Count queries for constructor expressions now also extract the respective selections. Closes #4341 Original pull request: #4361
mp911de
added a commit
that referenced
this pull request
Oct 15, 2026
Invert the relationship between the inherited grammar interface and actual count-rendering methods so that CountSelection remains the main component for rendering the count selection while a CountQueryTransformer only implements the methods necessary for rendering. See #4341 Original pull request: #4361
mp911de
pushed a commit
that referenced
this pull request
Oct 15, 2026
Introduce CountSelectionSupport to unify code paths for transforming queries into their count query representation. This commit fixes an issue where the created token stream missed to detect expressions correctly which resulted in broken rendering missing whitespaces between tokens. Count queries for constructor expressions now also extract the respective selections. Closes #4341 Original pull request: #4361
mp911de
added a commit
that referenced
this pull request
Oct 15, 2026
Invert the relationship between the inherited grammar interface and actual count-rendering methods so that CountSelection remains the main component for rendering the count selection while a CountQueryTransformer only implements the methods necessary for rendering. See #4341 Original pull request: #4361
mp911de
pushed a commit
that referenced
this pull request
Oct 15, 2026
Introduce CountSelectionSupport to unify code paths for transforming queries into their count query representation. This commit fixes an issue where the created token stream missed to detect expressions correctly which resulted in broken rendering missing whitespaces between tokens. Count queries for constructor expressions now also extract the respective selections. Closes #4341 Original pull request: #4361
mp911de
added a commit
that referenced
this pull request
Oct 15, 2026
Invert the relationship between the inherited grammar interface and actual count-rendering methods so that CountSelection remains the main component for rendering the count selection while a CountQueryTransformer only implements the methods necessary for rendering. See #4341 Original pull request: #4361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
CountSelectionSupportto unify code paths for transforming queries into their count query representation.This PR fixes an issue where the created token stream missed to detect expressions correctly which resulted in broken rendering missing whitespaces between tokens.
Count queries for constructor expressions now also extract the respective selections.
Closes: #4341